[18.0][ADD] database_autovacuum_tuning

[santostelmo]

Database Autovacuum Tuning helps administrators keep PostgreSQL healthy by
exposing recommended autovacuum settings in Odoo. It provides guidance for sizing thresholds and scale factors so large, busy databases
avoid table bloat and excessive vacuum lag. Use it to standardize autovacuum
configuration across environments and speed up maintenance operations without
manual tuning.

[santostelmo]

CI failling on auditlog module but don't see any relation with this PR:
Test: auditlog.tests.test_auditlog
AssertionError: Found unexpected attributes on res.groups: export_data unlink write auditlog_ruled_read auditlog_ruled_create auditlog_ruled_write read auditlog_ruled_unlink auditlog_ruled_export_data create

[wouitmil]

Great!

[simahawk]

can't we simply use the @autovacuum decorator?

[santostelmo]

We could but we probably will be mixing 2 goals:

1. @autovacuum removing obsolete or temporary data
2. cron_database_autovacuum_tuning tune vacuum config parameter on tables

[gurneyalex]

I agree with @santostelmo this would be confusing the purpose of both are totally different.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[hbrunn]

an existing approach is https://github.com/OCA/server-tools/tree/16.0/postgres_vacuum that makes vacuum an explicit action. maybe combine both?

[gurneyalex]

an existing approach is https://github.com/OCA/server-tools/tree/16.0/postgres_vacuum that makes vacuum an explicit action. maybe combine both?

Both can coexist, but the goal here is to rely on autovacuum, which is what I understand your module wants to avoid ("autovacuum is not recommended for busy databases, it can be a better choice to schedule this process manually"). In our experience, autovacuum works fine, especially if you manage to get rid of super long "idle in transaction" and "active" connections to the database, which essentially prevent autovacuum from running. The tuning that this module performs is another key factor to get a performant autovacuum as the default settings will not give good results for large tables with many updates.

It may well be that our use cases do not match yours and the patterns of transaction that lead to the postgres_vacuum addon are indeed not compatible with autovacuum. Both addons serve different purposes, it should be possible to install them together without any negative consequences, so I would be tempted to let them live in parallel.

[gurneyalex]

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3523-by-gurneyalex-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 234d851. Thanks a lot for contributing to OCA. ❤️