Skip to content

[17.0][MIG] mail_template_attachment_i18n: Migration to 17.0#3559

Merged
OCA-git-bot merged 16 commits intoOCA:17.0from
ForgeFlow:17.0-mig-mail_template_attachment_i18n
Apr 15, 2026
Merged

[17.0][MIG] mail_template_attachment_i18n: Migration to 17.0#3559
OCA-git-bot merged 16 commits intoOCA:17.0from
ForgeFlow:17.0-mig-mail_template_attachment_i18n

Conversation

@LauraCForgeFlow
Copy link
Copy Markdown
Contributor

@LauraCForgeFlow LauraCForgeFlow commented Mar 16, 2026

Standard migration, added some testing.

BhaveshHeliconia
BhaveshHeliconia approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

christian-ramos-tecnativa
christian-ramos-tecnativa suggested changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown

@christian-ramos-tecnativa christian-ramos-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Partner language mode is not working. Can you take a look? The preview and template options works properly

@LauraCForgeFlow LauraCForgeFlow force-pushed the 17.0-mig-mail_template_attachment_i18n branch from 71bcc53 to fcb4cf3 Compare April 14, 2026 14:16
@OCA-git-bot OCA-git-bot added mod:mail_template_attachment_i18n Module mail_template_attachment_i18n series:17.0 labels Apr 14, 2026
@LauraCForgeFlow LauraCForgeFlow force-pushed the 17.0-mig-mail_template_attachment_i18n branch from fcb4cf3 to 6da2f77 Compare April 15, 2026 06:31
@LauraCForgeFlow
Copy link
Copy Markdown
Contributor Author

LauraCForgeFlow commented Apr 15, 2026

Thanks for reviewing @christian-ramos-tecnativa! I have fixed the code to work correctly with the Partner language and added a test that covers that use case. I've also ported the changes to the v18 migration #3560, which depends on this one.

christian-ramos-tecnativa
christian-ramos-tecnativa approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown

@christian-ramos-tecnativa christian-ramos-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review, LGTM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 15, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Apr 15, 2026

Same comment: #3560 (comment)

tarteo and others added 15 commits April 15, 2026 16:45
@tarteo @LauraCForgeFlow
[ADD] mail_template_attachment_i18n: Mail Template Language Dependent…
14ba615 
… Attachments (OCA#1367)
@oca-travis @LauraCForgeFlow
[UPD] Update mail_template_attachment_i18n.pot
7e3081b
@OCA-git-bot @LauraCForgeFlow
[UPD] README.rst
258694b
@OCA-git-bot @LauraCForgeFlow
[ADD] icon.png
545ae64
@OCA-git-bot @LauraCForgeFlow
[UPD] README.rst
c9b7396
@XanderDeMatteis @LauraCForgeFlow
[IMP] mail_template_attachment_i18n: pre-commit stuff
0b7ce03
@XanderDeMatteis @LauraCForgeFlow
[MIG] mail_template_attachment_i18n: Migration to 16.0
c3b47bd
@LauraCForgeFlow
[IMP] mail_template_attachment_i18n: allow using mail template language
bcb15a0
@LauraCForgeFlow
[UPD] Update mail_template_attachment_i18n.pot
f8815cd
@OCA-git-bot @LauraCForgeFlow
[BOT] post-merge updates
463b512
@mymage @LauraCForgeFlow
Added translation using Weblate (Italian)
6e384dd
@mymage @LauraCForgeFlow
Translated using Weblate (Italian)
e10f205 
Currently translated at 100.0% (29 of 29 strings)

Translation: server-tools-16.0/server-tools-16.0-mail_template_attachment_i18n
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-mail_template_attachment_i18n/it/
@mymage @LauraCForgeFlow
Translated using Weblate (Italian)
dc5a26a 
Currently translated at 100.0% (29 of 29 strings)

Translation: server-tools-16.0/server-tools-16.0-mail_template_attachment_i18n
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-mail_template_attachment_i18n/it/
@LauraCForgeFlow
[IMP] mail_template_attachment_i18n: pre-commit auto fixes
8d46137
@LauraCForgeFlow
[MIG] mail_template_attachment_i18n: Migration to 17.0
c3404ee
@LauraCForgeFlow LauraCForgeFlow force-pushed the 17.0-mig-mail_template_attachment_i18n branch from 6da2f77 to 2352bca Compare April 15, 2026 14:50
@OCA-git-bot OCA-git-bot added mod:mail_template_attachment_per_lang Module mail_template_attachment_per_lang and removed mod:mail_template_attachment_i18n Module mail_template_attachment_i18n labels Apr 15, 2026
@LauraCForgeFlow LauraCForgeFlow force-pushed the 17.0-mig-mail_template_attachment_i18n branch from 2352bca to 9327e21 Compare April 15, 2026 14:52
@LauraCForgeFlow
Copy link
Copy Markdown
Contributor Author

LauraCForgeFlow commented Apr 15, 2026

@pedrobaeza I've renamed the module in a separate commit to make it easier to review. If everything looks good, I can squash the commits and port the changes to the v18 migration PR. Let me know if anything else is needed for the rename!

@LauraCForgeFlow LauraCForgeFlow force-pushed the 17.0-mig-mail_template_attachment_i18n branch from 9327e21 to c5495fa Compare April 15, 2026 16:03
@pedrobaeza pedrobaeza added this to the 17.0 milestone Apr 15, 2026
pedrobaeza
pedrobaeza approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 15, 2026

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-3559-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f3eb6f1 into OCA:17.0 Apr 15, 2026
9 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 15, 2026

Congratulations, your PR was merged at 638389d. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza mentioned this pull request Apr 16, 2026
Closed
@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Apr 16, 2026

Checking now, I wonder why this is here instead of OCA/mail...

@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Apr 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+2 more reviewers

@christian-ramos-tecnativa christian-ramos-tecnativa christian-ramos-tecnativa approved these changes

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:mail_template_attachment_per_lang Module mail_template_attachment_per_lang ready to merge series:17.0

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

9 participants

@LauraCForgeFlow @OCA-git-bot @pedrobaeza @christian-ramos-tecnativa @BhaveshHeliconia @tarteo @oca-travis @XanderDeMatteis @mymage