Skip to content

[18.0][IMP] base_tier_validation: support res.groups in addition to res.users in field-based validation#1081

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
kevinkhao:18.0-base_tier_validation_group
Oct 20, 2025
Merged

[18.0][IMP] base_tier_validation: support res.groups in addition to res.users in field-based validation#1081
OCA-git-bot merged 1 commit into
OCA:18.0from
kevinkhao:18.0-base_tier_validation_group

Conversation

@kevinkhao
Copy link
Copy Markdown
Contributor

@kevinkhao kevinkhao commented May 20, 2025 •
edited
Loading

No description provided.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 20, 2025

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@kevinkhao kevinkhao changed the title [IMP] base_tier_validation: support res.groups in addition to res.use… [IMP] base_tier_validation: support res.groups in addition to res.users in field-based validation May 20, 2025
@kevinkhao kevinkhao force-pushed the 18.0-base_tier_validation_group branch from 7e58ca6 to 6425290 Compare May 20, 2025 06:51
@kevinkhao kevinkhao mentioned this pull request May 20, 2025
Open
@kevinkhao kevinkhao force-pushed the 18.0-base_tier_validation_group branch from 6425290 to b0a4f98 Compare May 20, 2025 07:23
rousseldenis
rousseldenis reviewed May 20, 2025
View reviewed changes
Comment thread base_tier_validation/models/tier_review.py Outdated
def _check_reviewers(self, resource):
if not resource or resource._name not in ["res.users", "res.groups"]:
raise ValidationError(
self.env._("There are no res.users in the selected field")
Copy link
Copy Markdown
Contributor

@rousseldenis rousseldenis May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too technical message.

Suggested change
self.env._("There are no res.users in the selected field")
self.env._("There are no user or group in the selected field")

Copy link
Copy Markdown
Contributor Author

@kevinkhao kevinkhao May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@kevinkhao kevinkhao force-pushed the 18.0-base_tier_validation_group branch 2 times, most recently from 0e382fc to f9db455 Compare May 20, 2025 07:33
StefanRijnhart
StefanRijnhart reviewed Jun 2, 2025
View reviewed changes
Comment thread base_tier_validation/models/tier_review.py Outdated
@LoisRForgeFlow LoisRForgeFlow changed the title [IMP] base_tier_validation: support res.groups in addition to res.users in field-based validation [18.0][IMP] base_tier_validation: support res.groups in addition to res.users in field-based validation Jun 30, 2025
@kevinkhao kevinkhao force-pushed the 18.0-base_tier_validation_group branch from 9f96b57 to cc064b5 Compare July 10, 2025 08:22
StefanRijnhart
StefanRijnhart reviewed Jul 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes so far! One remaining comment.

Comment thread base_tier_validation/models/tier_review.py Outdated
@kevinkhao kevinkhao force-pushed the 18.0-base_tier_validation_group branch 3 times, most recently from c754087 to 643f081 Compare July 23, 2025 14:15
StefanRijnhart
StefanRijnhart approved these changes Jul 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StefanRijnhart
Copy link
Copy Markdown
Member

StefanRijnhart commented Aug 6, 2025

@LoisRForgeFlow @rousseldenis OK for you now?

@LoisRForgeFlow
Copy link
Copy Markdown
Contributor

LoisRForgeFlow commented Aug 7, 2025

@kevinkhao There is a conflict that will prevent merge, could you attend that?

LoisRForgeFlow
LoisRForgeFlow approved these changes Aug 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the conflicts mentioned, I have done a functional test locally and it works as expected 👍

@kevinkhao kevinkhao force-pushed the 18.0-base_tier_validation_group branch from 643f081 to 14d5383 Compare August 7, 2025 16:54
@kevinkhao
Copy link
Copy Markdown
Contributor Author

kevinkhao commented Aug 7, 2025 •
edited
Loading

@LoisRForgeFlow done!

@kevinkhao kevinkhao force-pushed the 18.0-base_tier_validation_group branch from 14d5383 to 78690b2 Compare August 7, 2025 17:08
@kevinkhao kevinkhao force-pushed the 18.0-base_tier_validation_group branch from 78690b2 to 03abaec Compare August 8, 2025 06:24
@kevinkhao
Copy link
Copy Markdown
Contributor Author

kevinkhao commented Aug 8, 2025

I made some changes to make codecov happy. Now it seems the testing pipeline fails at initialization time.

@StefanRijnhart
Copy link
Copy Markdown
Member

StefanRijnhart commented Aug 11, 2025

Test failure was caused by the Github glitch last week and are green on rerun.

@LoisRForgeFlow
Copy link
Copy Markdown
Contributor

LoisRForgeFlow commented Oct 20, 2025

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Oct 20, 2025

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1081-by-LoisRForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fd49613 into OCA:18.0 Oct 20, 2025
9 of 13 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Oct 20, 2025

Congratulations, your PR was merged at 0eaff63. Thanks a lot for contributing to OCA. ❤️

@simahawk simahawk mentioned this pull request Dec 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

+1 more reviewer

@rousseldenis rousseldenis rousseldenis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kevinkhao @OCA-git-bot @StefanRijnhart @LoisRForgeFlow @rousseldenis