[19.0][MIG] base_substate #1198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that because inheritance was poorly implemented in inheriting modules (such as sale_substate) this function was never called, hiding the bug. auto_delete_message was removed in odoo@9140ce06
Currently translated at 100.0% (33 of 33 strings) Translation: server-ux-17.0/server-ux-17.0-base_substate Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_substate/it/
bosd
force-pushed
the
19.0-mig-base_substate
branch
from
e1f5397 to
96cbcde
Compare
| @api.depends("line_ids") | ||
| def _compute_amount_total(self): | ||
| for record in self: | ||
| record.amount_total = 0 # Initialize to 0 |
Contributor
There was a problem hiding this comment.
You can do it outside the loop with self.amount_total = 0
rrebollo
reviewed
Dec 14, 2025
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Thank you for your contribution. Please, consider my suggestions.
|
|
||
| from odoo import api, fields, models | ||
| from odoo.exceptions import ValidationError | ||
|
|
There was a problem hiding this comment.
Suggested change
| from odoo.fields import Domain | |
Comment on lines
+50
to
+53
| domain = [ | ||
| ("target_state_value_id.target_state_value", "=", state_val), | ||
| ("target_state_value_id.base_substate_type_id", "=", substate_type.id), | ||
| ] |
There was a problem hiding this comment.
Suggested change
| domain = [ | |
| ("target_state_value_id.target_state_value", "=", state_val), | |
| ("target_state_value_id.base_substate_type_id", "=", substate_type.id), | |
| ] | |
| domain = ( | |
| Domain('target_state_value_id.target_state_value', '=', state_val) & | |
| Domain('target_state_value_id.base_substate_type_id', '=', substate_type.id) | |
| ) |
| def _get_substate_type(self): | ||
| """Override this method to change substate_type (get by xml id for example)""" | ||
| return self.env["base.substate.type"].search( | ||
| [("model", "=", self._name)], limit=1 |
There was a problem hiding this comment.
Suggested change
| [("model", "=", self._name)], limit=1 | |
| Domain("model", "=", self._name), limit=1 |
| ondelete="restrict", | ||
| default=lambda self: self._get_default_substate_id(), | ||
| index=True, | ||
| domain=lambda self: [("model", "=", self._name)], |
There was a problem hiding this comment.
Suggested change
| domain=lambda self: [("model", "=", self._name)], | |
| domain=lambda self: Domain("model", "=", self._name), |
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). | ||
|
|
||
| from odoo.addons.base.tests.common import BaseCommon | ||
|
|
There was a problem hiding this comment.
Suggested change
| from odoo.fields import Domain | |
| # Create access rights for the test models if they exist | ||
| model_names = ["base.substate.test.sale", "base.substate.test.sale.line"] | ||
| for model_name in model_names: | ||
| model = cls.env["ir.model"].search([("model", "=", model_name)], limit=1) |
There was a problem hiding this comment.
Suggested change
| model = cls.env["ir.model"].search([("model", "=", model_name)], limit=1) | |
| model = cls.env["ir.model"].search(Domain("model", "=", model_name), limit=1) |
Comment on lines
+26
to
+29
| [ | ||
| ("model_id", "=", model.id), | ||
| ("name", "ilike", f"access {model.name}%"), | ||
| ], |
There was a problem hiding this comment.
Suggested change
| [ | |
| ("model_id", "=", model.id), | |
| ("name", "ilike", f"access {model.name}%"), | |
| ], | |
| Domain("model_id", "=", model.id) \ | |
| & Domain("name", "ilike", f"access {model.name}%"), |
| # Clean up any access rights created during tests | ||
| model_names = ["base.substate.test.sale", "base.substate.test.sale.line"] | ||
| for model_name in model_names: | ||
| model = cls.env["ir.model"].search([("model", "=", model_name)], limit=1) |
There was a problem hiding this comment.
Suggested change
| model = cls.env["ir.model"].search([("model", "=", model_name)], limit=1) | |
| model = cls.env["ir.model"].search(Domain("model", "=", model_name), limit=1) |
Comment on lines
+53
to
+56
| [ | ||
| ("model_id", "=", model.id), | ||
| ("name", "ilike", f"access {model.name}%"), | ||
| ] |
There was a problem hiding this comment.
Suggested change
| [ | |
| ("model_id", "=", model.id), | |
| ("name", "ilike", f"access {model.name}%"), | |
| ] | |
| Domain("model_id", "=", model.id) \ | |
| & Domain("name", "ilike", f"access {model.name}%") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration using odoo-module-migrator
/ocabot migration base_substate .