[19.0][IMP] Update substates properly when state field is computed#1236
Merged
Conversation
Camille0907
force-pushed
the
19.0-imp-base_substate
branch
from
de785e2 to
4f17b6f
Compare
vvrossem
approved these changes
Feb 6, 2026
Camille0907
force-pushed
the
19.0-imp-base_substate
branch
from
4f17b6f to
6f2f147
Compare
If the state field on which the substate is based is computed, its update does not goes through `write` or `create` methods. In that cas we need to take care of the substate in ``_compute_field_value``. As an example, you can check [batch_substate](OCA/stock-logistics-workflow#2244): the batch state is computed in some cases (all picking set to done or cancel). Unit tests have been adapted to check this case.
Camille0907
force-pushed
the
19.0-imp-base_substate
branch
from
6f2f147 to
98d9bd2
Compare
imlopes
approved these changes
Feb 23, 2026
Contributor
|
This PR has the |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at a3bd477. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the state field on which the substate is based is computed, its update does not goes through
writeorcreatemethods. In that cas we need to take care of the substate in_compute_field_value.As an example, you can check stock_picking_batch_substate: the batch state is computed in some cases (all picking set to done or cancel).
Unit tests have been adapted to check this case.