[18.0] shopfloor_base: critical fixes #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was breaking _unregister_controllers since we don't get tuples
but EndpointRule objects.
Prior to this change the call failed like
File /odoo/external-src/shopfloor-app/shopfloor_base/models/shopfloor_app.py, line 166, in _registered_endpoint_rule_keys
return [x[0] for x in self._registered_routes()]
~^^^
TypeError: 'EndpointRule' object is not subscriptable
* ensure manifest url is always the same * improve comparison on handler options
The app was not using at all the base_rest dispatcher for restapi route type. This is because by default endpoint.route.handler use only http or json
Provides fix for existing installations.
Contributor
florentx
reviewed
Sep 12, 2025
| @@ -0,0 +1,32 @@ | |||
| # Copyright 2025 Camptocamp SA | |||
There was a problem hiding this comment.
There are two identical migration files. This one is redundant, isn't it?
Contributor
Author
There was a problem hiding this comment.
one is for whoever lands on 18.0.1.0.0 and one for who's already on 18..0.1.0.2. Although 1.0.3 should run as well in the 1st case, I prefer to keep it as is.
sebalix
approved these changes
Sep 12, 2025
Contributor
Author
|
/ocabot merge nobump |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 0b9f39e. Thanks a lot for contributing to OCA. ❤️ |
simahawk
commented
Oct 1, 2025
| registry = app._endpoint_registry | ||
| rules = list(registry.get_rules_by_group(app._route_group())) | ||
| for rule in rules: | ||
| rule.routing = dict(rule.routing, readonly=True, type="restapi") |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| rule.routing = dict(rule.routing, readonly=True, type="restapi") | |
| rule.routing = dict(rule.routing, readonly=False, type="restapi") |
This wrong, of course! Dumb me! I'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes to make it work properly on v18.
Most important fix is
shopfloor_base: fix routing registration
The app was not using at all the base_rest dispatcher for restapi route type.
This is because by defualt endpoint.route.handler use only http or json