[16.0][FIX] mail_show_follower: Company identification in _send()#1517
[16.0][FIX] mail_show_follower: Company identification in _send()#1517OCA-git-bot merged 1 commit intoOCA:16.0from
Conversation
|
Hi @yajo, |
nobuQuartile
changed the title
|
What a great day to merge this nice PR. Let's do it! |
|
@yajo your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1517-by-yajo-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
test are fixed in #1519 |
AungKoKoLin1997
left a comment
AungKoKoLin1997
left a comment
There was a problem hiding this comment.
@nobuQuartile Can you please rebase to fix the CI and get it merged?
Before this commit, 'Show Internal Users CC' would always be False, regardless of the setting in the company, in case the message came from a record with a company_id field but without a value assignment to it (e.g., a partner record with no company), as company would be an empty record. This commit fixes the behavior by capturing company from self.env in these cases.
nobuQuartile
force-pushed
the
16.0-fix-mail_show_follower
branch
from
865dfc0 to
01b20b7
Compare
I have rebased it. |
|
@yajo Can you please try to merge again? |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at cd3db85. Thanks a lot for contributing to OCA. ❤️ |
|
@nobuQuartile Please forward-port this. |
7 participants
Before this commit, 'Show Internal Users CC' would always be False, regardless of the setting in the company, in case the message came from a record with a company_id field but without a value assignment to it (e.g., a partner record with no company), as company would be an empty record.
This commit fixes the behavior by capturing company from self.env in these cases.
@qrtl QT5021