Skip to content

Comments

[16.0][ADD] new res_company_gitlab_link module#1586

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
grap:16.0-ADD-social_media_gitlab
Nov 17, 2025
Merged

[16.0][ADD] new res_company_gitlab_link module#1586
OCA-git-bot merged 1 commit intoOCA:16.0from
grap:16.0-ADD-social_media_gitlab

Conversation

@legalsylvain
Copy link
Contributor

This module adds a new 'Gitalb URL' field, at company level.

Gitlab is a code-sharing platform developed in Open Source. More information at https://about.gitlab.com/.

@hbrunn hbrunn changed the title [ADD] new social_media_gitlab module. [16.0][ADD] new social_media_gitlab module Jun 6, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are adding social_media_* modules for handling the social media posting and management, I don't think we should name this module this way. We can call it res_company_gitlab_link or similar, although I know Odoo core is calling the base module social_media.

@nilshamerlinck
Copy link

agree that current module naming could lead to confusion as the namespace social_media_* will be reserved for the connectors (social_media_linkedin, social_media_x, etc)

This module adds a new 'Gitalb URL' field, at company level.

Gitlab is a code-sharing platform developed in Open Source.
More information at https://about.gitlab.com/.
@legalsylvain legalsylvain force-pushed the 16.0-ADD-social_media_gitlab branch from ecaec05 to 3ca86e5 Compare November 17, 2025 09:21
@legalsylvain legalsylvain changed the title [16.0][ADD] new social_media_gitlab module [16.0][ADD] new res_company_gitlab_link module Nov 17, 2025
@legalsylvain
Copy link
Contributor Author

Hi @pedrobaeza and @nilshamerlinck. I renamed the module (res_company_gitlab_link).
same naming convention as https://github.com/OCA/social/tree/18.0/res_company_mastodon_link

Could you update your review ?

thanks !

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 17, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1586-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5b1b363. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 363b2d1 into OCA:16.0 Nov 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants