[18.0][MIG] storage_media_product: Migration to 18.0 #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and storage_media_product
This PR fixes the media displayed on the product variant form in the media tab. The change on the depends force the recomputation when an attibute value is changed on the product.media.relation. The other change fixes the attributes value that are tested to assign a media on a variant. It is the attribute set on the product variant that should be used and not all attribute values assigned to the product template. Forward port from: * OCA#116
Contributor
Author
|
Former PR already approved |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 8a985d2. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #441