Skip to content

Conversation

@kobros-tech
Copy link

No description provided.

@kobros-tech kobros-tech changed the title [18.0][ADD] survey_start_end_text [16.0][ADD] survey_start_end_text Jun 16, 2025
@kobros-tech kobros-tech force-pushed the 16.0-add-survey_start_end_text branch from daa47da to 4e77b35 Compare June 16, 2025 10:38
@kobros-tech kobros-tech force-pushed the 16.0-add-survey_start_end_text branch from 4e77b35 to d4d78f3 Compare June 16, 2025 10:55
Comment on lines +4 to +14
<xpath expr="//button/t[@t-if='survey.certification']" position="attributes">
<attribute name="t-if">False</attribute>
</xpath>
<xpath expr="//button//t[@t-if='False']" position="after">
<t t-if="survey.start_button_name">
<t t-out="survey.start_button_name" />
</t>
<t t-elif="survey.certification">
Start Certification
</t>
</xpath>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning, is it necessary to set the if condition to False in order to add it again later?

I suggest the following change:

Suggested change
<xpath expr="//button/t[@t-if='survey.certification']" position="attributes">
<attribute name="t-if">False</attribute>
</xpath>
<xpath expr="//button//t[@t-if='False']" position="after">
<t t-if="survey.start_button_name">
<t t-out="survey.start_button_name" />
</t>
<t t-elif="survey.certification">
Start Certification
</t>
</xpath>
<xpath expr="//button/t[@t-if='survey.certification']" position="after">
<t t-elif="survey.start_button_name">
<t t-out="survey.start_button_name" />
</t>
</xpath>

This should also account for the "certification" option.

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 9, 2025
@github-actions github-actions bot closed this Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants