[15.0][MIG] web_widget_mermaid by TheRealRoboHeart · Pull Request #2308 · OCA/web

TheRealRoboHeart · 2022-09-30T11:05:16Z

Migration of module web_widget_mermaid from v12.0 to v15.0

Using the last official version of module web_widget_mermaid as a base for the migration to v15.0

Using new asset definition via manifest and changed from static mermaid.js file to external CDN. Removed web_widget_mermaid_default_theme.scss and web_widget_mermaid_view.xml from mainfest (detailed description in upcoming commits)

This file is no longer needed since assets are now defined in manifest file.

Fixed ESLint messages. Due to issue with mermaid call, the definition has been moved to init and was deactivated for rule 'no-undef'. Inline comments has been moved to additional lines.

Since it seems like null values are no longer working for theme parameter, theme has been set to 'base' and theme config can completely move to web_widget_mermaid.js. web_widget_mermaid_default_theme.scss will be removed in upcoming commit.

SCSS file of default theme can be removed since the theme config moved to web_widget_mermaid.js.

oca-clabot · 2022-09-30T11:05:18Z

Hey @TheRealRoboHeart, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

@TheRealRoboHeart (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

• Add contributor: RoboHeart • Remove 'Upgrading' section from USAGE.rst

by oca-gen-addon-readme

tarteo

LGTM, tested locally

ivantodorovich · 2022-10-25T15:23:35Z

Thanks for the work done!

Please follow the steps described in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0#how-to to perform a migration. When migrating a module, we need to keep and respect the commit history: not simply copy & paste the code.

bosd · 2023-12-06T20:54:27Z

What is the status of this one?

etobella · 2024-01-12T08:47:37Z

/ocabot rebase

OCA-git-bot · 2024-01-12T08:47:44Z

@etobella The rebase process failed, because command git push --force TheRealRoboHeart tmp-pr-2308:15.0-mig-web_widget_mermaid failed with output:

remote: Repository not found.
fatal: repository 'https://github.com/TheRealRoboHeart/web/' not found

OCA-git-bot · 2024-01-31T07:25:06Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bosd · 2024-01-31T11:47:33Z

fatal: repository 'https://github.com/TheRealRoboHeart/web/' not found

@OCA-git-bot The correct repo is
https://github.com/TheRealRoboHeart/oca-web/tree/15.0-mig-web_widget_mermaid

dreispt · 2024-03-02T16:12:42Z

/ocabot merge nobump

OCA-git-bot · 2024-03-02T16:12:55Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-2308-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

OCA-git-bot · 2024-03-02T16:19:08Z

@dreispt The merge process could not be finalized, because command /tmp/tmp43e738b6/bin/python setup.py bdist_wheel --dist-dir /tmp/tmpigy2aeeo --bdist-dir /tmp/tmp1ez540ix --python-tag py3 failed with output:

/tmp/tmp43e738b6/lib/python3.8/site-packages/setuptools_scm/_integration/setuptools.py:30: RuntimeWarning: 
ERROR: setuptools==57.5.0 is used in combination with setuptools_scm>=8.x

Your build configuration is incomplete and previously worked by accident!
setuptools_scm requires setuptools>=61

Suggested workaround if applicable:
 - migrating from the deprecated setup_requires mechanism to pep517/518
   and using a pyproject.toml to declare build dependencies
   which are reliably pre-installed before running the build tools

  warnings.warn(
error in setup command: /tmp/tmpsb7c07ax/setup/web_widget_mermaid/odoo/addons must contain exactly one installable Odoo addon dir, found []

dreispt · 2024-03-09T15:19:27Z

Superseded by #2763

TheRealRoboHeart added 6 commits September 28, 2022 08:57

[ADD] web_widget_mermaid from v12.0

8d16b98

Using the last official version of module web_widget_mermaid as a base for the migration to v15.0

[IMP] Add assets

9b304e6

Using new asset definition via manifest and changed from static mermaid.js file to external CDN. Removed web_widget_mermaid_default_theme.scss and web_widget_mermaid_view.xml from mainfest (detailed description in upcoming commits)

[REM] Remove web_widget_mermaid_view.xml

711a617

This file is no longer needed since assets are now defined in manifest file.

[FIX] ESLint messages

3d4ad06

Fixed ESLint messages. Due to issue with mermaid call, the definition has been moved to init and was deactivated for rule 'no-undef'. Inline comments has been moved to additional lines.

[IMP] Add themeVariables to defaultConfig

8473465

Since it seems like null values are no longer working for theme parameter, theme has been set to 'base' and theme config can completely move to web_widget_mermaid.js. web_widget_mermaid_default_theme.scss will be removed in upcoming commit.

[REM] Remove web_widget_mermaid_default_theme.scss

5b3e750

SCSS file of default theme can be removed since the theme config moved to web_widget_mermaid.js.

TheRealRoboHeart added 4 commits September 30, 2022 13:35

[FIX] pre-commit issues (prettier)

c9a18c7

[UPD] Readme fragments

0ef1a78

• Add contributor: RoboHeart • Remove 'Upgrading' section from USAGE.rst

[ADD] Missing setup files

9a184d3

[UPD] Documentation files

39c36ea

by oca-gen-addon-readme

TheRealRoboHeart marked this pull request as ready for review September 30, 2022 12:26

tarteo approved these changes Oct 4, 2022

View reviewed changes

bofiltd approved these changes Jan 11, 2024

View reviewed changes

OCA-git-bot added the approved label Jan 11, 2024

etobella requested a review from bofiltd January 12, 2024 08:47

OCA-git-bot added the ready to merge label Jan 31, 2024

OCA-git-bot added a commit that referenced this pull request Mar 2, 2024

Merge PR #2308 into 15.0

9dd0402

Signed-off-by dreispt

OCA-git-bot added the bot is merging ⏳ label Mar 2, 2024

OCA-git-bot removed the bot is merging ⏳ label Mar 2, 2024

dreispt mentioned this pull request Mar 9, 2024

[15.0][MIG] web_widget_mermaid #2763

Open

dreispt approved these changes Mar 9, 2024

View reviewed changes

dreispt closed this Mar 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[15.0][MIG] web_widget_mermaid#2308

[15.0][MIG] web_widget_mermaid#2308
TheRealRoboHeart wants to merge 10 commits intoOCA:15.0from
TheRealRoboHeart:15.0-mig-web_widget_mermaid

TheRealRoboHeart commented Sep 30, 2022

Uh oh!

oca-clabot commented Sep 30, 2022

Uh oh!

tarteo left a comment

Uh oh!

ivantodorovich commented Oct 25, 2022

Uh oh!

bosd commented Dec 6, 2023

Uh oh!

etobella commented Jan 12, 2024

Uh oh!

OCA-git-bot commented Jan 12, 2024

Uh oh!

OCA-git-bot commented Jan 31, 2024

Uh oh!

bosd commented Jan 31, 2024

Uh oh!

dreispt commented Mar 2, 2024

Uh oh!

OCA-git-bot commented Mar 2, 2024

Uh oh!

OCA-git-bot commented Mar 2, 2024

Uh oh!

dreispt commented Mar 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

TheRealRoboHeart commented Sep 30, 2022

Uh oh!

oca-clabot commented Sep 30, 2022

Uh oh!

tarteo left a comment

Choose a reason for hiding this comment

Uh oh!

ivantodorovich commented Oct 25, 2022

Uh oh!

bosd commented Dec 6, 2023

Uh oh!

etobella commented Jan 12, 2024

Uh oh!

OCA-git-bot commented Jan 12, 2024

Uh oh!

OCA-git-bot commented Jan 31, 2024

Uh oh!

bosd commented Jan 31, 2024

Uh oh!

dreispt commented Mar 2, 2024

Uh oh!

OCA-git-bot commented Mar 2, 2024

Uh oh!

OCA-git-bot commented Mar 2, 2024

Uh oh!

dreispt commented Mar 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants