Skip to content

Conversation

@yajo
Copy link
Member

@yajo yajo commented Dec 22, 2023

This module prefers kanban sub-form views when using a tablet, or any other device with a touch screen, no matter its size.

@moduon MT-4472

This module prefers kanban sub-form views when using a tablet, or any other
device with a touch screen, no matter its size.

@moduon MT-4472
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review,

image

LGTM, thank you @yajo

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 let's go!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 22, 2023
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2701-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 15d0257 into OCA:16.0 Dec 27, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 27a5c86. Thanks a lot for contributing to OCA. ❤️

@arturoovf
Copy link

arturoovf commented Dec 27, 2023

Hi, I don't get what this module is supposed to do? I tried with my iPad with this module installed and I didn't see any difference, can you provide an example where to appreciate the changes? @yajo Thanks!

@Shide
Copy link
Contributor

Shide commented Jan 8, 2024

Hi, I don't get what this module is supposed to do? I tried with my iPad with this module installed and I didn't see any difference, can you provide an example where to appreciate the changes? @yajo Thanks!

According to the comment in .js file:

Create a new env that extends the original one but overrides the way Odoo considers this device small: it will be small if it has touch capabilities, not only if the screen is small.
In practice, this will make the inline subforms prefer the kanban mode if possible.

@Shide Shide deleted the 16.0-web_touchscreen branch January 8, 2024 07:02
@yajo
Copy link
Member Author

yajo commented Jan 9, 2024

Before:
image

After:
image

yajo added a commit to moduon/web that referenced this pull request Jan 9, 2024
@yajo
Copy link
Member Author

yajo commented Jan 9, 2024

I improved the readme in #2716

@arturoovf
Copy link

Before: image

After: image

Thank you!

Xino61122 pushed a commit to moduon/web that referenced this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants