[16.0][IMP] web_notify:t3894 Allow notify with sound #2923
Conversation
GabbasovDinar
changed the title
GabbasovDinar
force-pushed
the
16.0-t3894-web_notify-sound-on-notification
branch
from
e1ca00d to
d8630d6
Compare
| * specified settings like volume and looping. It also provides the ability | ||
| * to trigger actions when the audio playback ends. | ||
| */ | ||
| export class AudioPlayer extends Component { |
There was a problem hiding this comment.
this service is limited to predefined sound effect settings and does not allow you to specify a link to any sound. In my case, only the sound effect link is passed for playback, which allows any sound to be dynamically played back
There was a problem hiding this comment.
Yes, I mean, you can take inspiration in that code to implement your own sound service, resulting in a simpler impletation
There was a problem hiding this comment.
@chienandalu I was already inspired by this effect to write the current solution :-)
There was a problem hiding this comment.
Yes, I mean, you can take inspiration in that code to implement your own sound service, resulting in a simpler impletation
Hi @chienandalu, hope you are doing well! Would appreciate your review in order to proceed further.
GabbasovDinar
force-pushed
the
16.0-t3894-web_notify-sound-on-notification
branch
from
d8630d6 to
77e3a53
Compare
GabbasovDinar
force-pushed
the
16.0-t3894-web_notify-sound-on-notification
branch
2 times, most recently
from
0a1ad0d to
50e7956
Compare
|
Hi @chienandalu could you please review the code again? Thank you in advance! |
|
Hi @rvalyi , would appreciate you finding some time to review this. Really would be great to have it merged. |
GabbasovDinar
force-pushed
the
16.0-t3894-web_notify-sound-on-notification
branch
from
50e7956 to
802b34a
Compare
|
Hi @chienandalu @rvalyi would appreciate your review! We are using this module in several project already, I think community would definitely benefit from it too. |
|
This PR has the |
thank you @chienandalu ! |
|
@CarlosRoca13 Could you please merge the PR? Thank you. |
CarlosRoca13
left a comment
CarlosRoca13
left a comment
There was a problem hiding this comment.
/ocabot merge minor
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 06ef262. Thanks a lot for contributing to OCA. ❤️ |
6 participants
These changes allow you to send notifications with an audible alarm.