[16.0][MIG] web_widget_char_size: Migration to 16.0

[anusriNPS]

Migrating web_widget_char_size to 16.0

[HekkiMelody]

Functional review, LGTM

[renda-dev]

Code review, LGTM

[renda-dev]

nitpick(non-blocking): According to https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/maxlength it should be without the capital 'L'

Still works anyways tho

[anusriNPS]

Required to update actual definition in order to be aligned with HTML attributes name:
https://github.com/odoo/odoo/blob/16.0/addons/web/static/src/views/fields/char/char_field.js#L80

[renda-dev]

Everything is clear now, it's good as it is, thanks!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[renda-dev]

Greetings @OCA/web-maintainers, would anyone mind giving this one a look?

I personally think this is pretty useful :)

[CarlosRoca13]

Thank you for your effort! Please check that when fields have a widget assigned, it is not working. For example, by adding the options to the phone field in the res.partner form. Try loading the asset right after the char_field is loaded. Here’s how to do it: https://www.odoo.com/documentation/17.0/es/developer/reference/frontend/assets.html#after

You also have examples in the code 😄

[HekkiMelody]

Thank you for your effort! Please check that when fields have a widget assigned, it is not working. For example, by adding the options to the phone field in the res.partner form. Try loading the asset right after the char_field is loaded. Here’s how to do it: https://www.odoo.com/documentation/17.0/es/developer/reference/frontend/assets.html#after

You also have examples in the code 😄

I didn't even know this was a thing, I thought it was a given that it would only work with the default char widget.

Thank you for pointing it out!

[anusriNPS]

Thank you for your effort! Please check that when fields have a widget assigned, it is not working. For example, by adding the options to the phone field in the res.partner form. Try loading the asset right after the char_field is loaded. Here’s how to do it: https://www.odoo.com/documentation/17.0/es/developer/reference/frontend/assets.html#after

You also have examples in the code 😄

Hi,

I tried to implement as suggested by keeping the web_widget_char_size definition after target file of actual char_field.js file. But, it did not help to use option="{'size': 10}" from the view definition.
I also tried to check option="{'size': 10}" usage in phone field in the contact module in version 14. But, i did not see it's usage in version 14 as well.

I also think that in order to use "option={size: 10}" in the char field which uses "widget=phone", updating PhoneField, FormPhoneField definition would help to achieve the same.

As version 14 does not support this feature from web_widget_char_size module, is this addition required here?

Please let me know your views on this observation and also correct me if I am wrong.

[CarlosRoca13]

Okay, I see that PhoneField is not extending CharField. It’s a bit inconvenient, but I think we can do without it. If someone needs it in the future, we could create a web_widget_phone_size module.

/ocabot migration web_widget_char_size
/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3008-by-CarlosRoca13-bump-nobump, awaiting test results.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

Congratulations, your PR was merged at f3a122c. Thanks a lot for contributing to OCA. ❤️