Skip to content

Conversation

@CRogos
Copy link
Contributor

@CRogos CRogos commented Feb 8, 2025

Works as good as v17, but both version have the bug, that the expand all stops after 10 lines:
image

Has anyone an idea how to fix it. From debugging the code of this module, I did not find any error.

@OCA-git-bot
Copy link
Contributor

Hi @yajo, @rafaelbn,
some modules you are maintaining are being modified, check this out!

@CRogos CRogos mentioned this pull request Feb 8, 2025
46 tasks
@pedrobaeza
Copy link
Member

/ocabot migration web_group_expand

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 8, 2025
@CRogos
Copy link
Contributor Author

CRogos commented Mar 24, 2025

@astirpe could you do a review and maybe have an idea what could cause the bug in this module?

@BT-dmoreno
Copy link

@CRogos looks the runboat/build is kind of stuck. Could you maybe try re-running it again? Or do you have any other idea? For the rest tests and quality code checks looks all good.

@CRogos CRogos closed this Apr 10, 2025
@CRogos CRogos reopened this Apr 10, 2025
@CRogos CRogos force-pushed the 18.0-mig-web_group_expand branch from 5d8d3c5 to 711a368 Compare April 10, 2025 10:11
@CRogos
Copy link
Contributor Author

CRogos commented Apr 10, 2025

@BT-dmoreno I've rebased the branch

@BT-dmoreno
Copy link

@OCA/web-maintainers could you please take a look and merge this if good?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link
Contributor Author

CRogos commented Apr 10, 2025

@pedrobaeza can you merge and maybe know someone who could have a look on the described bug?

@pedrobaeza
Copy link
Member

/ocabot migration web_group_expand
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3085-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 62643dc into OCA:18.0 Apr 10, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1db3daa. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 18.0-mig-web_group_expand branch April 10, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.