[18.0][MIG] web_remember_tree_column_width #3114

JasminSForgeFlow · 2025-03-07T11:45:35Z

Standard Migration

Adapt 18.0 new hook code for change/update width of list

@ForgeFlow

AaronHForgeFlow

Functional review 👍 Thank you.

Can't do a proper code review, as my knowledge in js is limited. Added a couple of minor comments.

web_remember_tree_column_width/static/src/js/list_renderer.esm.js

web_remember_tree_column_width/readme/CREDITS.md

AaronHForgeFlow

Thanks! LGTM functional + soft code review 👍

OCA-git-bot · 2025-03-12T12:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sanderlienaerts · 2025-04-16T07:00:43Z

Can we get this PR merged?

mylbco · 2025-04-22T06:59:10Z

Can we get this merged ?

salimChoura1 · 2025-04-22T20:57:47Z

Can we get this merged ?

BT-aleonard · 2025-04-23T14:29:11Z

Can we merge this, please?

StefanRijnhart

Mmm, this looks like a modified copy of https://github.com/odoo/odoo/blob/18.0/addons/web/static/src/views/list/column_width_hook.js. Is it documented anywhere that this is the case? Are the changes annotated properly? Is there a more maintainable way of reusing at least parts of the code in that file?

JasminSForgeFlow · 2025-04-24T06:52:38Z

Mmm, this looks like a modified copy of https://github.com/odoo/odoo/blob/18.0/addons/web/static/src/views/list/column_width_hook.js. Is it documented anywhere that this is the case? Are the changes annotated properly? Is there a more maintainable way of reusing at least parts of the code in that file?

that is used as a hook, and it is not possible to inherit it

StefanRijnhart · 2025-04-24T08:33:39Z

Mmm, this looks like a modified copy of https://github.com/odoo/odoo/blob/18.0/addons/web/static/src/views/list/column_width_hook.js. Is it documented anywhere that this is the case? Are the changes annotated properly? Is there a more maintainable way of reusing at least parts of the code in that file?

that is used as a hook, and it is not possible to inherit it

But items like function getWidthSpecs or the various constants seem unchanged. Can't you at least import these items from the Odoo code? Or is it because they are not exported?

StefanRijnhart · 2025-04-24T08:36:38Z

In any case, please document the origin of the code and annotate your changes to it.

… widths Remember the tree columns' widths across sessions, and after filtering, grouping, or reordering.

this fixes scss file not found error after installing the module

…on column Fix an error when retrieving column sizes for lists containing one or more list_button columns. This error occurs when a list_button column is placed between other columns in the list. This type of column is excluded from the querySelector string used to retrieve column headers, which can cause the index to shift and the column size to change when the list is displayed.

StefanRijnhart · 2025-04-28T08:00:41Z

@JasminSForgeFlow Thanks. You can squash my commit in your migration commit and share credits by mentioning me with Co-authored-by: in the commit message.
Do you experience the same issue with the missing th in which case the modified size is not stored? Maybe we should mention it as a known issue.

JasminSForgeFlow · 2025-04-28T08:26:39Z

@JasminSForgeFlow Thanks. You can squash my commit in your migration commit and share credits by mentioning me with Co-authored-by: in the commit message. Do you experience the same issue with the missing th in which case the modified size is not stored? Maybe we should mention it as a known issue.

Sure, I'll update commit.

I haven't faced such issue, have you faced an issue with users' last view?

StefanRijnhart · 2025-04-28T08:29:19Z

@JasminSForgeFlow Yes, as I indicated I encountered the same error, but uncaught in your version on this PRs runbot. See the screenshot above. I am now catching this condition, but the size cannot be stored in that case.

JasminSForgeFlow · 2025-04-28T08:38:48Z

@JasminSForgeFlow Yes, as I indicated I encountered the same error, but uncaught in your version on this PRs runbot. See the screenshot above. I am now catching this condition, but the size cannot be stored in that case.

But you mentioned that you solved it in your version, didn't you?

StefanRijnhart · 2025-04-28T08:52:59Z

@JasminSForgeFlow unfortunately, I did not see how to solve the issue. Like I said,

I also check if th is null in one of the events. It solves an exception that also occurs in version. When it happens, the event passes a th element that can not be used to retrieve the td. The only thing is, when that happens, the modified column width is not stored. Not sure if this is a critical issue.

Co-authored-by: Stefan Rijnhart <stefan@opener.amsterdam>

JasminSForgeFlow · 2025-04-28T08:57:43Z

@JasminSForgeFlow unfortunately, I did not see how to solve the issue. Like I said,

I also check if th is null in one of the events. It solves an exception that also occurs in version. When it happens, the event passes a th element that can not be used to retrieve the td. The only thing is, when that happens, the modified column width is not stored. Not sure if this is a critical issue.

Okay, I have added it to know issue, and commit is also updated.
Thanks

StefanRijnhart

Thanks for taking my suggestions!

OCA-git-bot · 2025-04-29T03:57:36Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

TomAlbrechtQuatra

Functional & Technical review
Thanks!

StefanRijnhart · 2025-04-29T12:52:18Z

@OCA/web-maintainers this one should be ready for merge

etobella

/ocabot merge nobump

OCA-git-bot · 2025-04-29T13:07:30Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3114-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot · 2025-04-29T13:14:18Z

Congratulations, your PR was merged at feca976. Thanks a lot for contributing to OCA. ❤️

StefanRijnhart · 2025-05-23T10:04:32Z

FYI this module broke 4 days ago due to a change in Odoo. Fixed in #3177

Bart-dh · 2025-08-07T08:51:38Z

@JasminSForgeFlow This does not work at all in Odoo 18 Enterprise edition. Is it only tested in CE, or is there perhaps something interfering in our database?

etobella · 2025-08-07T09:02:24Z

It is tested in CE, not in EE, as some of us don't have access to EE. Actually, OCA only tests in CE. If you want, you can try to find the reason and make it compatible.

StefanRijnhart · 2025-08-07T09:13:21Z

@Bart-dh Using this in EE, but check the known issue discussed above. For us, it works most of the time.

-- edit -- meant to say EE.

AaronHForgeFlow · 2025-08-07T12:20:28Z

I tested it in EE and no issues so far.

StefanRijnhart · 2025-08-29T10:10:57Z

@Bart-dh I'm suspecting there may be an issue with list views that contain buttons. Buttons may mess up the mapping of fields to list columns. Are there buttons in the views that don't work for you?

Bart-dh · 2025-08-29T11:39:52Z

@Bart-dh I'm suspecting there may be an issue with list views that contain buttons. Buttons may mess up the mapping of fields to list columns. Are there buttons in the views that don't work for you?

Ahh yes, indeed there are buttons! There is the default 'View record' button, but also custom buttons.

StefanRijnhart · 2025-09-04T07:50:05Z

I fixed the roadmap issue from this PR in #3273, because it becomes quite prevalent in busy treeviews. @Bart-dh you might want to try that version to see if it solves your problems as well.

JasminSForgeFlow marked this pull request as ready for review March 7, 2025 11:45

AaronHForgeFlow reviewed Mar 7, 2025

View reviewed changes

web_remember_tree_column_width/static/src/js/list_renderer.esm.js Outdated Show resolved Hide resolved

web_remember_tree_column_width/readme/CREDITS.md Outdated Show resolved Hide resolved

JasminSForgeFlow force-pushed the 18.0-mig-web_remember_tree_column_width branch from 1db02d7 to f26d5a3 Compare March 10, 2025 09:04

AaronHForgeFlow approved these changes Mar 10, 2025

View reviewed changes

MiquelRForgeFlow approved these changes Mar 10, 2025

View reviewed changes

OCA-git-bot added the approved label Mar 10, 2025

psugne mentioned this pull request Mar 10, 2025

[MIG] web_remember_tree_column_width: Migration to 18.0 versada/web#10

Merged

OCA-git-bot added the ready to merge label Mar 12, 2025

StefanRijnhart requested changes Apr 24, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels Apr 24, 2025

frahikLV and others added 11 commits April 24, 2025 17:26

[ADD] web_tree_column_width_remember: Remember the tree view columns'…

a4bc668

… widths Remember the tree columns' widths across sessions, and after filtering, grouping, or reordering.

[UPD] Update web_remember_tree_column_width.pot

168340c

[UPD] README.rst

e6aef2b

[ADD] icon.png

da853c0

[15.0][FIX] web_remember_tree_column_width: use correct module name

269af54

this fixes scss file not found error after installing the module

[MIG] web_remember_tree_column_width: Migration to 16.0

9b5a3d0

[UPD] Update web_remember_tree_column_width.pot

ac3890d

[UPD] README.rst

2009188

[UPD] README.rst

f13cf7e

[BOT] post-merge updates

36b353e

[MIG] web_remember_tree_column_width: Migration to 18.0

b558c28

Co-authored-by: Stefan Rijnhart <stefan@opener.amsterdam>

JasminSForgeFlow force-pushed the 18.0-mig-web_remember_tree_column_width branch from 4b7f50c to b558c28 Compare April 28, 2025 08:56

StefanRijnhart approved these changes Apr 28, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 28, 2025

TomAlbrechtQuatra approved these changes Apr 29, 2025

View reviewed changes

etobella approved these changes Apr 29, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Apr 29, 2025

OCA-git-bot merged commit 92efcbf into OCA:18.0 Apr 29, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 29, 2025

MiquelRForgeFlow deleted the 18.0-mig-web_remember_tree_column_width branch April 29, 2025 13:33

Uh oh!

[18.0][MIG] web_remember_tree_column_width #3114

[18.0][MIG] web_remember_tree_column_width #3114

Uh oh!

Conversation

JasminSForgeFlow commented Mar 7, 2025

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 12, 2025

Uh oh!

sanderlienaerts commented Apr 16, 2025

Uh oh!

mylbco commented Apr 22, 2025

Uh oh!

salimChoura1 commented Apr 22, 2025

Uh oh!

BT-aleonard commented Apr 23, 2025

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

JasminSForgeFlow commented Apr 24, 2025

Uh oh!

StefanRijnhart commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanRijnhart commented Apr 24, 2025

Uh oh!

StefanRijnhart commented Apr 28, 2025

Uh oh!

JasminSForgeFlow commented Apr 28, 2025

Uh oh!

StefanRijnhart commented Apr 28, 2025

Uh oh!

JasminSForgeFlow commented Apr 28, 2025

Uh oh!

StefanRijnhart commented Apr 28, 2025

Uh oh!

JasminSForgeFlow commented Apr 28, 2025

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 29, 2025

Uh oh!

TomAlbrechtQuatra left a comment

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart commented Apr 29, 2025

Uh oh!

etobella left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 29, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Apr 29, 2025

Uh oh!

StefanRijnhart commented May 23, 2025

Uh oh!

Bart-dh commented Aug 7, 2025

Uh oh!

etobella commented Aug 7, 2025

Uh oh!

StefanRijnhart commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AaronHForgeFlow commented Aug 7, 2025

Uh oh!

StefanRijnhart commented Aug 29, 2025

Uh oh!

Bart-dh commented Aug 29, 2025

Uh oh!

StefanRijnhart commented Apr 24, 2025 •

edited

Loading

StefanRijnhart commented Aug 7, 2025 •

edited

Loading