[18.0][MIG] web_filter_header_button: Migration to 18.0 #3133
Conversation
chienandalu
force-pushed
the
18.0-mig-web_filter_header_button
branch
2 times, most recently
from
8e25391 to
ac2c345
Compare
CarlosRoca13
left a comment
CarlosRoca13
left a comment
There was a problem hiding this comment.
LGTM 👍 please @sergio-teruel review
|
/ocabot migration web_filter_header_button |
|
I've found a bug and I'm looking for a way to fix it. I'll let you know as soon as I have it. |
Now we can configure group filters to show up along the other filters so users can easily access those as well. TT49232
When there are too many buttons, they won't fit in the window and they will overlap with other ui elemnets. We can prevent it putting them in their own row. TT49431
In custom views, like the reconciliation one, that use the control panel we must prevent loading the FilterButton component. TT49664
…rrors referring self
CarlosRoca13
force-pushed
the
18.0-mig-web_filter_header_button
branch
from
ac2c345 to
2e6d4ce
Compare
|
The error was caused by field-type filters, but it doesn't make sense for them to be in the header buttons because they require a value to be evaluated. So, the easiest solution is to exclude them in the initial filter. |
|
Please @sergio-teruel review this PR 😄 |
sergio-teruel
left a comment
sergio-teruel
left a comment
There was a problem hiding this comment.
Functional review Ok!!
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at a8c9721. Thanks a lot for contributing to OCA. ❤️ |
5 participants
Tasks done:
cc @Tecnativa TT54366
please review @CarlosRoca13 @sergio-teruel