[18.0][FIX] web_ir_actions_act_window_message: env.services.rpc is not a function

[sergioM-S73]

1 - When creating an "ir.actions.act_window.message" and clicking on the buttons, this error appears:

I have refactored the component to use "useService" for ORM, removing the use of env.services.rpc

2 - After, testing with an ir_actions_act_window_message in sale.order, which contains a button that triggers the action_confirm action, I encountered this error.

This happens because if the page is refreshed within the form view of the sale.order, the context of the list view is lost, so when the switchView function is called, it executes this code:

In this case, the controllerStack array contains a list view, but it doesn't contain the view field.

If we access the sale.order form view directly from the list view without refreshing the page, the controllerStack array correctly contains the list view information.

The _refreshWidget function has been modified to prevent this error when the user refreshes the page in the form view, and it now triggers a window.location.reload() to maintain functionality.

[sergioM-S73]

@yvaucher @miguel-S73 When using this module I get this errors, can you review it??

[Reyes4711-S73]

LGTM

[adrip-s73]

LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[Reyes4711-S73]

@OCA/website-maintainers Please, can you merge this PR?

[hbrunn]

thanks for this, I wonder if this ever worked or if the v18 migration just was a horrible hack job.

Given env from props isn't used any more, please remove all references to this.

And please review #3353 to avoid this kind of unpleasantness in the future (actual unittests pending)

[sergioM-S73]

@hbrunn Changes made, thanks for the feedback!

[hbrunn]

please remove env in web_ir_actions_act_window_message.esm.js too

[sergioM-S73]

@hbrunn done

[hbrunn]

thanks, if you put this into your v19 migration, that should be fine too.

You might want to review the PR I pointed to for having this merged in v18

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3264-by-hbrunn-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at be59864. Thanks a lot for contributing to OCA. ❤️