[18][IMP] web_chatter_position: improve form and chatter layout styles

[StefanRijnhart]

Move functional elements of web_sheet_full_width into web_chatter_position, as it is otherwise deprecated.

Supersedes #3183 (after first having proposed the changes into that PR's branch in c4a8-odoo#17).

[OCA-git-bot]

Hi @trisdoan,
some modules you are maintaining are being modified, check this out!

[bealdav]

18.0 broken by web_systray_button_init_action module

[StefanRijnhart]

@bealdav green in #3275

[MohamedOsman7]

Code & functional review LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[anajuaristi]

Hello @StefanRijnhart
Just to let you know there is a bug in web_chatter_position that is being solved in
#3282

I don't know if this is also happening in V18, but if yes, IMHO the patch should be also included here or in another PR.
My2cents.

[StefanRijnhart]

@anajuaristi I saw that. That patch seems to break attachment rendering in our 16.0 setups for users that force the chatter below, possibly in combination with web_enterprise. We're now moving away from using this module. I might investigate during the OCA days, but you are right that this change is not compatible with that PR and we should probably not be merging this now.

[trisdoan]

Hello @StefanRijnhart, fyi, that patch tries to fix a feature, which was added in #3040 for 16.0. And it's not forwarded to 18.0 yet

[StefanRijnhart]

@trisdoan Perfect, thanks. I now see that #3282 is indeed a proposed fix for the issue we encountered in our setups, caused by #3040. In any case, this PR needs to be refactored to fit onto any port of #3040 which is likely to happen.

[DavidJForgeFlow]

Hi, can someone merge this?

[hbrunn]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3272-by-hbrunn-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 600b2b0. Thanks a lot for contributing to OCA. ❤️