Skip to content

[18.0][ADD] web_widget_product_label_section_and_note_full_label#3344

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
ForgeFlow:18.0-add-web_widget_product_label_section_and_note_full_label
Nov 17, 2025
Merged

[18.0][ADD] web_widget_product_label_section_and_note_full_label#3344
OCA-git-bot merged 1 commit into
OCA:18.0from
ForgeFlow:18.0-add-web_widget_product_label_section_and_note_full_label

Conversation

@LauraCForgeFlow
Copy link
Copy Markdown
Contributor

No description provided.

@pedrobaeza
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza added this to the 18.0 milestone Oct 24, 2025
@LauraCForgeFlow
Copy link
Copy Markdown
Contributor Author

Hi @pedrobaeza, thanks for taking a look. We actually developed this module since the web_widget_product_label_section_and_note_name_visibility module did not cover some necessities we had.

The main limitation we found is that it only allows toggling the visibility of the product name in the description while the line is editable. Once the line becomes read-only, the eye icon disappears and it’s no longer possible to see or guess the full content of the description directly on screen (so users have to open the print preview or send the document to check it).

That behavior works fine when you occasionally want to hide product names, but in business cases where line descriptions are frequently customized, we think it’s more practical and safer to always display the full information. This helps avoid mistakes sending information, and ensures what users see on screen matches what will appear on the final reports.

@pedrobaeza
Copy link
Copy Markdown
Member

OK, as you prefer. I think the cons you mention is easily avoidable showing the icon in readonly.

Copy link
Copy Markdown
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is simpler for the business need.

I actually tested web_widget_product_label_section_and_note_name_visibility and it didn't even work as expected because with the "eye enabled" I still cannot see the full description

image image

(runboat, only web_widget_product_label_section_and_note_name_visibility installed)

@DavidJForgeFlow
Copy link
Copy Markdown
Contributor

@pedrobaeza did you see last Lois message? Do you agree with merging this?

@pedrobaeza
Copy link
Copy Markdown
Member

Yes, I'm not blocking this. Go ahead with the second review and merge.

Copy link
Copy Markdown
Contributor

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍 Could you merge @pedrobaeza ?

@pedrobaeza
Copy link
Copy Markdown
Member

Hehe, OK.

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3344-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 52b3353 into OCA:18.0 Nov 17, 2025
9 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at ea46a95. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants