[18.0][ADD] web_widget_product_label_section_and_note_full_label#3344
Conversation
|
I think you already have it covered with https://github.com/OCA/web/tree/18.0/web_widget_product_label_section_and_note_name_visibility |
|
Hi @pedrobaeza, thanks for taking a look. We actually developed this module since the web_widget_product_label_section_and_note_name_visibility module did not cover some necessities we had. The main limitation we found is that it only allows toggling the visibility of the product name in the description while the line is editable. Once the line becomes read-only, the eye icon disappears and it’s no longer possible to see or guess the full content of the description directly on screen (so users have to open the print preview or send the document to check it). That behavior works fine when you occasionally want to hide product names, but in business cases where line descriptions are frequently customized, we think it’s more practical and safer to always display the full information. This helps avoid mistakes sending information, and ensures what users see on screen matches what will appear on the final reports. |
|
OK, as you prefer. I think the cons you mention is easily avoidable showing the icon in readonly. |
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
For me this is simpler for the business need.
I actually tested web_widget_product_label_section_and_note_name_visibility and it didn't even work as expected because with the "eye enabled" I still cannot see the full description
(runboat, only web_widget_product_label_section_and_note_name_visibility installed)
|
@pedrobaeza did you see last Lois message? Do you agree with merging this? |
|
Yes, I'm not blocking this. Go ahead with the second review and merge. |
DavidJForgeFlow
left a comment
There was a problem hiding this comment.
Functional review 👍 Could you merge @pedrobaeza ?
|
Hehe, OK. /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at ea46a95. Thanks a lot for contributing to OCA. ❤️ |
No description provided.