[19.0][MIG] web_search_with_and: Migration to 19.0#3352
Conversation
Add README.rst Too short underline for module title in README.rst Improving module meta information Version 1.0 W391 blank line at end of file Remove module description because README.rst is there web_search_with_and: Latest OCA conventions
|
LGTM, Functional Test OK |
|
Hi, really appreciate your migration PR. After testing, the feature works great, only one minor thing I think you need to re-check. The input dropdown does not totally disappear after I press Enter. 
I think you can put this line of code to close the input dropdown. I'm not sure if it's the right way to handle it. But you can take it into account. 
|
lef-adhoc
force-pushed
the
19.0-mig-web_search_with_and
branch
from
b671ccb to
90a7413
Compare
|
@Vang-NguyenPhu Thank you very much, that's all sorted! |
Vang-NguyenPhu
left a comment
Vang-NguyenPhu
left a comment
There was a problem hiding this comment.
Functional test & code LGTM
|
This PR has the |
|
hey @lef-adhoc thank you for your contribution! Is this ok to squash the technical commits? The ones with |
lef-adhoc
force-pushed
the
19.0-mig-web_search_with_and
branch
from
90a7413 to
02b642f
Compare
|
@ivs-cetmix Is it okay now? |
@lef-adhoc absolutely 😉 Thank you for your contribution! /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 1df78d6. Thanks a lot for contributing to OCA. ❤️ |
18 participants
No description provided.