Skip to content

[19.0][FIX] web_responsive: change code to be compatible upstream#3544

Merged
OCA-git-bot merged 1 commit into
OCA:19.0from
Tecnativa:19.0-fix-web_responsive-upstream_change
May 12, 2026
Merged

[19.0][FIX] web_responsive: change code to be compatible upstream#3544
OCA-git-bot merged 1 commit into
OCA:19.0from
Tecnativa:19.0-fix-web_responsive-upstream_change

Conversation

@pedrobaeza
Copy link
Copy Markdown
Member

After odoo/odoo#263628, we need this change for the module to work.

Forward-port of #3536.

@Tecnativa

After odoo/odoo#263628, we need this change for the module to work.

Forward-port of OCA#3536.
@pedrobaeza pedrobaeza added this to the 19.0 milestone May 11, 2026
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @SplashS, @Tardo,
some modules you are maintaining are being modified, check this out!

@pedrobaeza
Copy link
Copy Markdown
Member Author

The runboat image doesn't still contain the upstream change, so let's wait till tomorrow.

Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor

On Runboat, after login, only a white screen is rendered. The same issue is also occurring on this PR #3537 Runboat instance.

@pedrobaeza
Copy link
Copy Markdown
Member Author

That's because this one is running on yesterday code. Let's merge it and it should normalize everything.

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-3544-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e0278e7 into OCA:19.0 May 12, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 2295cf7. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 19.0-fix-web_responsive-upstream_change branch May 12, 2026 10:13
@codebykyle
Copy link
Copy Markdown

codebykyle commented May 12, 2026

Hey all, I just ran a build with the merged code, and am getting the white screen with the error:

Caused by: Error: Element '<xpath expr="//t[@t-if='this.ui.isSmall']" position="attributes">
            <attribute name="t-if">false</attribute>
        </xpath>' cannot be located in element tree

Anything I'm needing to do?

When you say runboat is running yesterdays code, are you meaning Odoo CE or this PR? Sorry, run a downstream codebase, not sure what I'm missing

@pedrobaeza
Copy link
Copy Markdown
Member Author

Update the Odoo base code as well.

@codebykyle
Copy link
Copy Markdown

Thanks @pedrobaeza. It was a docker cache that was causing the issue. We were able to get that fixed up on our side. Appreciate the quick response and your hard work maintaining this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants