[BP][IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality

[NICO-SOLUTIONS]

• replace banner.js with new consent.js script using domain and identifier
• back ported from V17 PR ([IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality #1110)

[ioans73]

LGTM

[mariancuadranetkia]

LGTM!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[NICO-SOLUTIONS]

@pedrobaeza
hey pedro. Could you remove the stale tag pls? would be great..

[pedrobaeza]

/ocabot merge major

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1116-by-pedrobaeza-bump-major, awaiting test results.

[OCA-git-bot]

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1116-by-pedrobaeza-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[NICO-SOLUTIONS]

@pedrobaeza
Hey Pedro,
I noticed that when running the OCA pre-commit hooks on GitHub, the setuptools-odoo hooks fail with the following error:

ModuleNotFoundError: No module named 'pkg_resources'

It seems that this may be happening because the GitHub Actions environment does not have setuptools (and therefore pkg_resources) installed before the hooks are executed. On my local environment, where setuptools is installed, the pre-commit hooks run successfully.

Could this issue be related to my local setup, or is it something that occurs specifically in the GitHub Actions environment?

[pedrobaeza]

Please put a PR updating the copier template, that includes the patch for this.

[NICO-SOLUTIONS]

@pedrobaeza
Hey Pedro, thanks as always for your guidance!

Since I’m not that familiar with the procedure yet, I just wanted to check upfront: would adding setuptools as an additional_dependencies for this hook in .pre-commit-config.yaml.jinja be enough, or is there anything else I should keep in mind?

- repo: https://github.com/acsone/setuptools-odoo
  rev: {{ repo_rev.setuptools_odoo }}
  hooks:
    - id: setuptools-odoo-make-default
      additional_dependencies:
        - setuptools
    {%- if generate_requirements_txt %}

[pedrobaeza]

pre-commit fixed in #1173 executing the update of the template with the copier tool.

[pedrobaeza]

/ocabot merge major

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1116-by-pedrobaeza-bump-major, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 2e7fdb7. Thanks a lot for contributing to OCA. ❤️

[NICO-SOLUTIONS]

@pedrobaeza
thx 🙏