[16.0][IMP] shopfloor: Add a parser to searches #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
This was referenced Apr 7, 2025
Merged
rousseldenis
force-pushed
the
16.0-imp-shopfloor-parse-barcode-dro
branch
from
d3d6094 to
19363ab
Compare
simahawk
reviewed
May 27, 2025
simahawk
reviewed
May 27, 2025
rousseldenis
force-pushed
the
16.0-imp-shopfloor-parse-barcode-dro
branch
2 times, most recently
from
5889c0b to
bd7b26b
Compare
Author
As a some barcodes can represent more than one kind of record, add a helper to parse and return values.
rousseldenis
force-pushed
the
16.0-imp-shopfloor-parse-barcode-dro
branch
from
06f95d7 to
426acd9
Compare
Author
Author
jbaudoux
reviewed
Jul 9, 2025
| return None | ||
|
|
||
| def expiration_date_from_scan(self, barcode): | ||
| # TODO |
Author
There was a problem hiding this comment.
That's following @simahawk
For the time being, we don't search for expiration dates but we need to have a handler to get a parse result for dates from GS1
jbaudoux
approved these changes
Jul 18, 2025
27 tasks
Contributor
|
/ocabot merge minor |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 5d6c6c0. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some flows like GS1, a barcode representation can contain multiple content (e.g.: product, lot, expiration date, ...).
In current flows, we allow only one record return from the searches based on barcode scan.
In order to change the behavior when some extra data is found in barcodes, we add the parsed result in the search result.
e.g.: For reception flows, if we scan a GS1 and the lot is not found, we want to pre-fill expiration date for instance