Skip to content

[14.0][FIX] shopfloor_mobile_base: fix searchbar focus#767

Merged
OCA-git-bot merged 2 commits into
OCA:14.0from
camptocamp:14.0--shopfloor-mobile-base--focus-searchbar
Nov 20, 2023
Merged

[14.0][FIX] shopfloor_mobile_base: fix searchbar focus#767
OCA-git-bot merged 2 commits into
OCA:14.0from
camptocamp:14.0--shopfloor-mobile-base--focus-searchbar

Conversation

@JuMiSanAr
Copy link
Copy Markdown

@JuMiSanAr JuMiSanAr commented Oct 16, 2023 •
edited
Loading

The searchbar wasn't always ready for scanned inputs unless the user manually clicked on it.
Using focus() is not enough, but combining it with click() did work in our tests.

ref: cos-4175 & cos-4242

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Oct 16, 2023

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

TDu
TDu reviewed Nov 6, 2023
View reviewed changes
Comment thread shopfloor_mobile/static/wms/src/scenario/zone_picking.js
@JuMiSanAr JuMiSanAr force-pushed the 14.0--shopfloor-mobile-base--focus-searchbar branch 4 times, most recently from 358e949 to 05c85a0 Compare November 9, 2023 14:14
@JuMiSanAr JuMiSanAr force-pushed the 14.0--shopfloor-mobile-base--focus-searchbar branch from 05c85a0 to 3ae9b87 Compare November 9, 2023 14:25
@simahawk
Copy link
Copy Markdown

simahawk commented Nov 13, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Nov 13, 2023

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-767-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 13, 2023
@OCA-git-bot
Merge PR #767 into 14.0
74bf0a9 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Nov 13, 2023

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-767-by-simahawk-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sebalix
Copy link
Copy Markdown

sebalix commented Nov 20, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Nov 20, 2023

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-767-by-sebalix-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f16b7a3 into OCA:14.0 Nov 20, 2023
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Nov 20, 2023

Congratulations, your PR was merged at 476bf18. Thanks a lot for contributing to OCA. ❤️

@nicolas-delbovier-acsone nicolas-delbovier-acsone mentioned this pull request Apr 22, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes

+1 more reviewer

@TDu TDu TDu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JuMiSanAr @OCA-git-bot @simahawk @sebalix @TDu