Skip to content

[14.0][ADD] shopfloor_full_location_reservation: Full location reservation for shopfloor#792

Merged
OCA-git-bot merged 2 commits into
OCA:14.0from
mt-software-de:14-full_location_reservation_shopfloor
Aug 11, 2025
Merged

[14.0][ADD] shopfloor_full_location_reservation: Full location reservation for shopfloor#792
OCA-git-bot merged 2 commits into
OCA:14.0from
mt-software-de:14-full_location_reservation_shopfloor

Conversation

@mt-software-de
Copy link
Copy Markdown

No description provided.

@mt-software-de
Copy link
Copy Markdown
Author

cc @jbaudoux

@mt-software-de
Copy link
Copy Markdown
Author

Tests are missing

_inherit = "shopfloor.zone.picking"

def _handle_full_location_package_reservation(self, package):
return package and self.work.menu.full_location_reservation
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a full location reservation, it is a full package reservation.

If you had scanned a product not part of a package, it should trigger a full product reservation. Same for lot.

full_location_reservation_is_possible = fields.Boolean(
compute="_compute_full_location_reservation_is_possible"
)
full_location_reservation = fields.Boolean(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be replaced by full_source_reservation ?

@jbaudoux
Copy link
Copy Markdown
Contributor

jbaudoux commented Dec 12, 2023

This was initially developed for the location content transfer scenario but it doesn't apply properly to other scenarios. I think this should be slightly adapted to become more generic.

cc @rousseldenis

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 14, 2024
@github-actions github-actions Bot closed this May 19, 2024
@jbaudoux jbaudoux added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels May 22, 2024
@jbaudoux jbaudoux reopened this May 22, 2024
@mt-software-de mt-software-de force-pushed the 14-full_location_reservation_shopfloor branch from 31b23c6 to 8e8ca98 Compare August 11, 2025 08:10
@mt-software-de
Copy link
Copy Markdown
Author

mt-software-de commented Aug 11, 2025

@jbaudoux @rousseldenis This is now used quite some time in production. How should we move forward with this?
I cherry-picked your fix @rousseldenis b4cffd4
IMO this PR and the v16 PR would be ready to merge.

@mt-software-de mt-software-de force-pushed the 14-full_location_reservation_shopfloor branch from 684d9ec to cac81b0 Compare August 11, 2025 08:52
…ion on move but on move line

As a stock move can point to several move lines on several stock locations, don't do
the full reservation process on move but on lines.
@mt-software-de mt-software-de force-pushed the 14-full_location_reservation_shopfloor branch from cac81b0 to 5509f77 Compare August 11, 2025 09:13
@jbaudoux
Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-792-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 11, 2025
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Copy Markdown
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-792-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6746127 into OCA:14.0 Aug 11, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at fbde718. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants