Skip to content

fix: remove unused color field from sector events#100

Merged
fank merged 1 commit intomainfrom
fix/remove-sector-color-field
Mar 7, 2026
Merged

fix: remove unused color field from sector events#100
fank merged 1 commit intomainfrom
fix/remove-sector-color-field

Conversation

@fank
Copy link
Copy Markdown
Member

@fank fank commented Mar 7, 2026

Summary

  • Remove the color field from sector capture events — it was never populated by any code path
  • fnc_trackSectors.sqf always sent empty strings for color
  • Sector event format reverts to [objectType, unitName, side, [posX, posY, posZ]]
  • Companion PRs: extension and web

Test plan

  • No functional change — color was always empty

The color field was never populated by any code path — fnc_trackSectors
always sent empty strings. Remove it from the event format to keep the
pipeline simple. Format: [objectType, unitName, side, [posX, posY, posZ]]
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the data structure for sector events by eliminating an unused color field. This field consistently held an empty string and served no functional purpose, resulting in a cleaner and more efficient event data structure without affecting existing functionality. The change improves code clarity and reduces unnecessary data transmission.

Highlights

  • Removed Unused Field: The color field has been removed from sector capture events, as it was never populated by any code path and always sent as an empty string.
  • Updated Event Format: The sector event format now reverts to [objectType, unitName, side, [posX, posY, posZ]], simplifying the data structure.
  • Cleaned Event Dispatch: fnc_trackSectors.sqf no longer sends an empty string for the color parameter when dispatching sector events.
Changelog
  • addons/recorder/fnc_handleCustomEvent.sqf
    • Updated the example for sector captured events to reflect the new, simplified format.
    • Modified the event parsing logic to no longer expect or process the color parameter.
  • addons/recorder/fnc_trackSectors.sqf
    • Adjusted the contested and captured event calls to remove the empty color parameter from the data array.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused color field from sector capture events. The changes in fnc_trackSectors.sqf correctly adjust the event payload creation, and fnc_handleCustomEvent.sqf is updated to parse the new event format. The modifications are consistent and address the stated goal of the pull request.

@fank fank merged commit 69fae93 into main Mar 7, 2026
1 check passed
@fank fank deleted the fix/remove-sector-color-field branch March 7, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant