fix: remove unused color field from sector events#100
Conversation
The color field was never populated by any code path — fnc_trackSectors always sent empty strings. Remove it from the event format to keep the pipeline simple. Format: [objectType, unitName, side, [posX, posY, posZ]]
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the data structure for sector events by eliminating an unused Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the unused color field from sector capture events. The changes in fnc_trackSectors.sqf correctly adjust the event payload creation, and fnc_handleCustomEvent.sqf is updated to parse the new event format. The modifications are consistent and address the stated goal of the pull request.
Summary
fnc_trackSectors.sqfalways sent empty strings for color[objectType, unitName, side, [posX, posY, posZ]]Test plan