Conversation
Sector tracking used getPosATL which gives height relative to terrain, inconsistent with the rest of the capture pipeline (captureLoop, projectile tracking) which all use getPosASL. For accurate 3D rendering without a heightmap, all recorded positions must be in the same absolute coordinate system. Also fixes the example comment in handleCustomEvent.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the method for reporting object positions within the recording system, specifically for sector capture and contested events. By consistently using Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the sector tracking logic to use getPosASL instead of getPosATL for recording sector positions, aiming for a consistent coordinate system for 3D playback. The change is applied in fnc_trackSectors.sqf for sector capture/contested events, and a related code example in fnc_handleCustomEvent.sqf is updated from getPos to getPosASL to match. The implementation aligns with the stated goal of using ASL coordinates for all recorded positions.
1 participant
Summary
getPosATL→getPosASLinfnc_trackSectors.sqffor sector capture/contested eventsfnc_handleCustomEvent.sqf(getPos→getPosASL)All recorded positions now consistently use
getPosASLfor accurate 3D rendering in the same absolute coordinate system as the capture loop and projectile tracking.Test Plan