Conversation
Add fnc_setFocusStart and fnc_setFocusEnd which send :MISSION:FOCUS_START: and :MISSION:FOCUS_END: to the extension. Register both as PREP functions and CBA server events (OCAP_setFocusStart, OCAP_setFocusEnd) with listener handles.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the OCAP2 recording system by empowering mission makers to programmatically control the playback focus range. By exposing Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature to set a playback focus range from SQF scripts, which is a valuable addition for mission makers. However, a critical security vulnerability exists as the newly added CBA server events lack proper access control, potentially allowing any player to manipulate the recording's focus range; implementing admin authorization checks for these event handlers is recommended. Furthermore, there is a critical issue in the argument parsing within fnc_setFocusStart.sqf and fnc_setFocusEnd.sqf, where the event name is incorrectly used as the frame number, which will cause errors.
Design and plan docs served their purpose during implementation.
Summary
Adds
OCAP_setFocusStartandOCAP_setFocusEndCBA server events for mission makers to define a playback focus range from SQF.:MISSION:FOCUS_START:/:MISSION:FOCUS_END:to the extensionUsage
Companion PR