Skip to content

fix: use BIS_fnc_addScriptedEventHandler for sector OwnerChanged event#96

Merged
fank merged 1 commit intomainfrom
fix/sector-scripted-event-handler
Mar 6, 2026
Merged

fix: use BIS_fnc_addScriptedEventHandler for sector OwnerChanged event#96
fank merged 1 commit intomainfrom
fix/sector-scripted-event-handler

Conversation

@fank
Copy link
Copy Markdown
Member

@fank fank commented Mar 6, 2026

Summary

  • OwnerChanged on ModuleSector_F is a scripted event, not an engine event handler
  • Using addEventHandler silently did nothing — sector captures were never recorded
  • Switched to BIS_fnc_addScriptedEventHandler which is the correct API for scripted events

Test plan

  • Place sectors in editor, capture one — verify OCAP timeline shows the capture event
  • Place a sector via Zeus mid-mission, capture it — verify it's also tracked
  • Run hemtt release — no more L-S02UE warnings

OwnerChanged is a scripted event on ModuleSector_F, not an engine event.
Using addEventHandler silently failed — the handler never fired, so sector
captures were not being recorded. Switch to BIS_fnc_addScriptedEventHandler.
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where sector capture events were not being recorded due to an incorrect API call. By switching from addEventHandler to BIS_fnc_addScriptedEventHandler, the system will now correctly track and log OwnerChanged events for sectors, resolving a silent failure that prevented proper event recording.

Highlights

  • Event Handler Correction: The OwnerChanged event on ModuleSector_F was incorrectly treated as an engine event handler, leading to addEventHandler silently failing to register the event.
  • API Usage Fix: Switched to BIS_fnc_addScriptedEventHandler, which is the correct API for registering scripted events, ensuring sector capture events are now properly tracked.
Changelog
  • addons/recorder/fnc_trackSectors.sqf
    • Corrected the method for registering the 'OwnerChanged' event handler for sectors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug where sector capture events were not being recorded due to the incorrect use of addEventHandler for a scripted event. The switch to BIS_fnc_addScriptedEventHandler is the correct approach for handling the OwnerChanged event on ModuleSector_F objects. The implementation is sound, and I found no issues with the changes.

@fank fank merged commit cbf1417 into main Mar 6, 2026
1 check passed
@fank fank deleted the fix/sector-scripted-event-handler branch March 6, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant