fix: use BIS_fnc_addScriptedEventHandler for sector OwnerChanged event#96
fix: use BIS_fnc_addScriptedEventHandler for sector OwnerChanged event#96
Conversation
OwnerChanged is a scripted event on ModuleSector_F, not an engine event. Using addEventHandler silently failed — the handler never fired, so sector captures were not being recorded. Switch to BIS_fnc_addScriptedEventHandler.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where sector capture events were not being recorded due to an incorrect API call. By switching from Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where sector capture events were not being recorded due to the incorrect use of addEventHandler for a scripted event. The switch to BIS_fnc_addScriptedEventHandler is the correct approach for handling the OwnerChanged event on ModuleSector_F objects. The implementation is sound, and I found no issues with the changes.
Summary
OwnerChangedonModuleSector_Fis a scripted event, not an engine event handleraddEventHandlersilently did nothing — sector captures were never recordedBIS_fnc_addScriptedEventHandlerwhich is the correct API for scripted eventsTest plan
hemtt release— no moreL-S02UEwarnings