refactor: standardize command names to :RESOURCE:ACTION: pattern#128
refactor: standardize command names to :RESOURCE:ACTION: pattern#128
Conversation
Summary of ChangesHello @fank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the command naming scheme used throughout the extension to introduce a standardized Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request standardizes command names to a :RESOURCE:ACTION: pattern, improving consistency and clarity across the project. This refactoring impacts documentation, main application logic, data models, and worker handlers, ensuring all components align with the new naming convention. The changes are well-implemented and tested, contributing positively to the codebase's maintainability.
…ttern Rename all command strings from inconsistent naming (overloaded :NEW:, mixed verb/noun ordering, bare nouns) to a consistent :RESOURCE:ACTION: pattern. This is a coordinated change with the addon repo. Key changes: - System commands namespaced under :SYS: (INIT, VERSION, LOG, DIR, TIMESTAMP) - Entity commands use :RESOURCE:CREATE/STATE: (SOLDIER, VEHICLE, PLACED, MARKER) - Event commands namespaced under :EVENT: (GENERAL, KILL, PROJECTILE, CHAT, RADIO) - Mission commands flipped to :MISSION:START/SAVE: - Telemetry uses :TELEMETRY:FRAME: - Callbacks aligned (:EXT:READY: → :SYS:READY:)
fank
force-pushed
the
refactor/command-naming
branch
from
c492672 to
208b742
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
1 participant
Summary
:NEW:, mixed verb/noun ordering, bare nouns) to a consistent:RESOURCE:ACTION:pattern:SYS:(INIT, VERSION, LOG, DIR, TIMESTAMP):RESOURCE:CREATE/STATE:(SOLDIER, VEHICLE, PLACED, MARKER):EVENT:(GENERAL, KILL, PROJECTILE, CHAT, RADIO):MISSION:START/SAVE::EXT:READY:→:SYS:READY:)Coordinated change
Must be deployed together with the addon PR: OCAP2/addon#80
Test plan
go test ./...passes