Skip to content

Conversation

@fank
Copy link
Member

@fank fank commented Feb 2, 2026

Summary

  • Changed all 16 occurrences of strconv.ParseInt to strconv.ParseFloat for capture frame parsing
  • The Arma addon sends capture frame values as floats (e.g., "1.988") but handlers expected integers
  • The uint() conversion truncates the decimal portion as expected

Test plan

  • Tests pass locally
  • Deploy updated DLL and verify MARKER:CREATE events no longer fail with parsing errors

The Arma addon sends capture frame values as floats (e.g., "1.988")
but all handlers were using strconv.ParseInt which fails on decimal
values. Changed to strconv.ParseFloat and the uint conversion
truncates the decimal portion.
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/OCAP2/extension/v5/internal/handlers 1.24% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/OCAP2/extension/v5/internal/handlers/handlers.go 1.24% (ø) 9099 113 8986

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@fank fank merged commit 3bed06e into main Feb 2, 2026
3 checks passed
@fank fank deleted the fix/capture-frame-float-parsing branch February 2, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants