fix: use path.Clean for URL paths to fix Windows static file serving#124
Merged
fix: use path.Clean for URL paths to fix Windows static file serving#124
Conversation
filepath.Clean converts forward slashes to backslashes on Windows, which broke the path validation in paramPath since URL paths always use forward slashes. This caused all static file requests to return 404 on Windows. Also add index.html fallback for directory requests.
- Test root path serves index.html - Test nested paths with forward slashes work correctly - Add paramPath unit tests for path validation
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
path.Cleaninstead offilepath.Cleanfor URL path validationfilepath.Cleanconverts/to\on Windows, breaking the path validation since URLs always use forward slashes/now serves/index.html)Test plan