fix: add distinct icons and colors for event types#332
Conversation
- Add FlagIcon for captured/capturedFlag events (blue) - Use AlertTriangleIcon for contested events (orange) - Use TerminalIcon for terminal hack events (orange) - Remove invisible em dash separator from EndMissionEvent rows
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user interface by introducing distinct visual cues for various game events. It assigns unique icons and colors to 'captured', 'contested', and 'terminal hack' events, moving away from a generic representation. Additionally, it refines the display of 'EndMissionEvent' rows by removing an unnecessary separator, improving overall readability and user experience. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Coverage Report for ui
File Coverage
|
||||||||||||||||||||||||||||||||||||||
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully adds distinct icons and colors for different event types, improving the clarity of the event log. The changes are well-implemented. I've added two comments: one suggests refactoring related functions to improve long-term maintainability by reducing code duplication, and the other proposes a UI fix for spacing by using a CSS class, aligning with our styling guidelines.
Replace TargetIcon with a door/exit icon for mission end events, better conveying that the mission has ended.
* fix: add distinct icons and colors for capture/contested/terminal events - Add FlagIcon for captured/capturedFlag events (blue) - Use AlertTriangleIcon for contested events (orange) - Use TerminalIcon for terminal hack events (orange) - Remove invisible em dash separator from EndMissionEvent rows * fix: use DoorExitIcon for EndMissionEvent events Replace TargetIcon with a door/exit icon for mission end events, better conveying that the mission has ended. * refactor: merge eventIcon and eventColor into single eventStyle function
* fix: improve readability of force totals and event timestamps Bump color from --text-dimmest to --text-dimmer for the force total counts in the top bar and event timestamps in the side panel, as they were too dark to read comfortably. * fix: add distinct icons and colors for event types (#332) * fix: add distinct icons and colors for capture/contested/terminal events - Add FlagIcon for captured/capturedFlag events (blue) - Use AlertTriangleIcon for contested events (orange) - Use TerminalIcon for terminal hack events (orange) - Remove invisible em dash separator from EndMissionEvent rows * fix: use DoorExitIcon for EndMissionEvent events Replace TargetIcon with a door/exit icon for mission end events, better conveying that the mission has ended. * refactor: merge eventIcon and eventColor into single eventStyle function * fix: also improve readability of event weapon text
1 participant
Summary
FlagIconfor captured/capturedFlag events (blue--accent-primary)AlertTriangleIconfor contested sector events (orange--accent-warning)TerminalIconfor terminal hack events (orange--accent-warning)DoorExitIconfor EndMissionEvent (purple, replacesTargetIcon)Previously, captured, contested, and terminal hack events all fell through to the generic
ActivityIconwith#888color.Test plan