Skip to content

fix: swagger ui missing openapi.json #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fank merged 4 commits into from
May 3, 2026
Merged

fix: swagger ui missing openapi.json #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32051db
fix: swagger ui missing openapi.json
smitt14ua May 1, 2026
9eee4e1
fix: openapi.json from absolute to relative
smitt14ua May 1, 2026
a464d17
refactor: remove unused parameter
smitt14ua May 1, 2026
85daccd
test: fix swagger ui test
smitt14ua May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/server/openapi_ui.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func OpenAPIUIHandler(_ string) http.Handler {
<title>OCAP2 Web API</title>
</head>
<body>
<script id="api-reference" data-url="swagger/openapi.json" data-configuration='{"darkMode":true,"showDeveloperTools":"never"}'></script>
<script id="api-reference" data-url="openapi.json" data-configuration='{"darkMode":true,"showDeveloperTools":"never"}'></script>
<script src="https://cdn.jsdelivr.net/npm/@scalar/api-reference"></script>
</body>
</html>`
Expand Down
2 changes: 1 addition & 1 deletion internal/server/openapi_ui_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ func TestOpenAPIUIHandler(t *testing.T) {
assert.Equal(t, "text/html; charset=utf-8", rec.Header().Get("Content-Type"))

body := rec.Body.String()
assert.Contains(t, body, `data-url="swagger/openapi.json"`, "should use relative spec URL")
assert.Contains(t, body, `data-url="openapi.json"`, "should use relative spec URL")
assert.NotContains(t, body, "/ignored/absolute/path", "should not use absolute spec URL")
assert.Contains(t, body, `"darkMode":true`, "should enable dark mode")
assert.Contains(t, body, "OCAP2 Web API", "should have the page title")
Expand Down
Loading