Skip to content

fix(ui): add space separator between EndMissionEvent side and message#454

Merged
fank merged 3 commits into
mainfrom
fix/ui-event-space
May 24, 2026
Merged

fix(ui): add space separator between EndMissionEvent side and message#454
fank merged 3 commits into
mainfrom
fix/ui-event-space

Conversation

@smitt14ua
Copy link
Copy Markdown
Contributor

@smitt14ua smitt14ua commented May 23, 2026

Summary

The EndMissionEvent row in the Events tab rendered the side label and the mission message in adjacent <span> elements with no whitespace between them, causing them to appear concatenated (e.g. WESTMission ended).

Added a {" "} text node between the two spans, matching the separator pattern already used for HitKilledEvent name tokens.

Before:
image

After:
image

Test plan

  • Open a recording that contains an end-mission event — side label and message are visually separated by a space.
  • cd ui && npx vitest run — all 34 tests pass.

Files

  • ui/src/pages/recording-playback/components/EventsTab.tsx — one-line fix in EndMissionEvent render branch.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 23, 2026

Coverage Report for ui

Status Category Percentage Covered / Total
🔵 Lines 98.95%
🟰 ±0%
5517 / 5575
🔵 Statements 98.3%
🟰 ±0%
7779 / 7913
🔵 Functions 97.8%
⬆️ +0.01%
2225 / 2275
🔵 Branches 89.56%
🟰 ±0%
2463 / 2750
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
ui/src/pages/recording-playback/components/EventsTab.tsx 94.11%
⬆️ +0.11%
87.4%
🟰 ±0%
92.13%
⬆️ +0.27%
94.4%
⬆️ +0.07%
25, 68, 78, 248, 268-278
Generated in workflow #673 for commit 2b3f7c4 by the Vitest Coverage Report Action

@smitt14ua smitt14ua requested a review from fank May 23, 2026 20:59
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a space separator between the event side label and the message in the EventsTab component to improve UI spacing. A review comment suggests wrapping the side label and the space in a conditional rendering component to prevent a leading space glitch if the side data is missing, ensuring consistency with other parts of the codebase.

Comment thread ui/src/pages/recording-playback/components/EventsTab.tsx Outdated
smitt14ua and others added 2 commits May 24, 2026 00:01
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@fank fank merged commit 7c835cd into main May 24, 2026
3 checks passed
@fank fank deleted the fix/ui-event-space branch May 24, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants