Remove group when going back in time and unit does not exist yet#7
Merged
Remove group when going back in time and unit does not exist yet#7
Conversation
fank
changed the title
indig0fox
reviewed
Jul 10, 2021
Member
indig0fox
left a comment
indig0fox
left a comment
There was a problem hiding this comment.
Is this a draft? Remove doesn't do anything yet and at the moment just leaves an orphaned marker outside of future entity control here
Member
Author
|
No it works, because its already implemented but never called. |
Member
|
NOOP method on parent allows calls to method always and if overridden by child class (i.e. unit) then will perform the operation of removing the unit from the group when the unit isn't present on that frame |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.