Skip to content

fix: register storage engines for all CLI convert commands #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fank merged 1 commit into from
Jan 31, 2026
Merged

fix: register storage engines for all CLI convert commands #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/ocap-webserver/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ func runConvert(args []string) error {

ctx := context.Background()

// Register storage engines for CLI commands that read data directly
storage.RegisterEngine(storage.NewProtobufEngine(setting.Data))
storage.RegisterEngine(storage.NewFlatBuffersEngine(setting.Data))

switch {
case *status:
return showConversionStatus(ctx, repo)
Expand Down Expand Up @@ -125,10 +129,6 @@ func convertSingleFile(ctx context.Context, repo *server.RepoOperation, inputFil
baseName = baseName[:len(baseName)-len(ext)]
}

// Register engines
storage.RegisterEngine(storage.NewProtobufEngine(dataDir))
storage.RegisterEngine(storage.NewFlatBuffersEngine(dataDir))

// Check if operation exists in database - if so, use worker for consistent behavior
if op, err := repo.GetByFilename(ctx, baseName); err == nil && op != nil {
log.Printf("Converting operation %d: %s (format: %s)", op.ID, op.Filename, format)
Expand Down
Loading