fix: register storage engines for all CLI convert commands#92
Merged
Conversation
Move engine registration from convertSingleFile() to the start of runConvert(), ensuring engines are available for all convert subcommands including --all, --status, and --set-format. Previously, convertAll() was missing engine registration, causing "unknown storage engine: flatbuffers" errors when using --all --format flatbuffers.
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convertSingleFile()to the start ofrunConvert()--all,--input,--status,--set-format)Problem
Running
./app convert --all --format flatbuffersfailed with:The
convertAll()code path was missing the engine registration thatconvertSingleFile()had.Solution
Register engines once at the start of
runConvert()after loading settings, following the pattern that whoever loads settings is responsible for registering engines:NewHandler()registers enginesrunConvert()registers enginesTest plan
go test ./...passes