fix: hide null extension/addon versions in About modal#95
Merged
Conversation
Extension and addon versions come from mission data, so they are null until a mission is loaded. Now: - Hide extension/addon version lines when no mission is loaded - Show 'N/A' for server version if unavailable - Fix language switch to use ui object instead of this - Add server version handling to language switch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extension and addon versions come from mission data (the Arma 3 OCAP extension that recorded the mission), so they are null until a mission is loaded.
Changes:
uiobject instead ofthisBefore
After (before loading a mission)
After (after loading a mission)