[do not merge] test adaption for #374 #375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improve recursive validation of multi-level textequiv consistency:
* regions (e.g. Table) may contain regions (e.g. Text)
* 'fix' recursively by going bottom-up
* better reports, more logging
* simplify
- add recursive validation of multi-level coordinate consistency:
* add all region types, also consider Baseline
* introduce 2 more error cases into ValidationReport:
- CoordinateValidityException (self-intersecting, non-contiguous,
too short or negative path)
- CoordinateConsistencyException (child extends beyond parent)
* introduce 2 new parameters:
- check_coords (valid paths and consistent child/parent relations
within the normal hierarchy)
- check_baseline (the same only for TextLine.Coords vs Baseline)
* expose them as 1 new CLI parameter `--page-discipline` (analoguous to
`--page-strictness` for text) as enum:
- poly (only check_coords)
- baseline (only check_baseline)
- both
- off
* use shapely.geometry for checks
* handle PAGE ideosyncrasies (no Coords or ID at PageType / Baseline)
* try to be efficient (re-use Polygon objects)
- remove unnecessary/redundant instantiation and method from PageValidator
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 84.75% 84.91% +0.16%
==========================================
Files 30 31 +1
Lines 1764 1856 +92
Branches 341 356 +15
==========================================
+ Hits 1495 1576 +81
- Misses 218 222 +4
- Partials 51 58 +7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot push to https://github.com/bertsky/core/tree/validate-coords PR is just for CI.