Skip to content

Conversation

@kba
Copy link
Member

@kba kba commented Dec 27, 2019

Yet untested, soliciting feedback on the interface before working further on this.

@kba kba requested review from bertsky, cneud and wrznr December 27, 2019 14:11
@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #384 into master will decrease coverage by 2.48%.
The diff coverage is 81.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   84.91%   82.43%   -2.49%     
==========================================
  Files          31       39       +8     
  Lines        1856     2260     +404     
  Branches      356      402      +46     
==========================================
+ Hits         1576     1863     +287     
- Misses        222      334     +112     
- Partials       58       63       +5
Impacted Files Coverage Δ
ocrd/ocrd/cli/workspace.py 75.16% <ø> (ø)
ocrd_utils/ocrd_utils/constants.py 100% <ø> (ø) ⬆️
ocrd_utils/ocrd_utils/__init__.py 66.92% <100%> (+0.26%) ⬆️
ocrd/ocrd/processor/__init__.py 100% <100%> (ø)
ocrd/ocrd/resolver.py 98.85% <100%> (+0.05%) ⬆️
..._validators/ocrd_validators/workspace_validator.py 82.8% <100%> (+2.51%) ⬆️
ocrd/ocrd/cli/validate.py 100% <100%> (ø)
ocrd_models/ocrd_models/utils.py 100% <100%> (ø) ⬆️
ocrd_modelfactory/ocrd_modelfactory/__init__.py 87.09% <100%> (+0.88%) ⬆️
ocrd/ocrd/processor/base.py 86.58% <31.25%> (-13.42%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c9236...2910862. Read the comment docs.

Copy link
Collaborator

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@wrznr
Copy link
Contributor

wrznr commented Jan 7, 2020

@wrznr Push!

@kba
Copy link
Member Author

kba commented Jan 16, 2020

I have now tested most of the functionality.

ocrd validate workspace and ocrd validate zip have been disabled for now, since they are rather complex and are already easily accessible via their resp. subcommands.

ocrd validate tasks will now either check just the syntax/executable existence or do full input/output group validation if a workspace is provided.

ocrd validate parameters validates whether JSON parameters are valid according to the definition of the resp. tool in the resp. ocrd-tool.json

ocrd validate tool-json validates ocrd-tool.json. You can now say ocrd validate tool-json in the root of a MP repo instead of ocrd ocrd-tool ocrd-tool.json validate which is more efficient and will boost YOUR productivity with 15 characters less to type!

@kba kba changed the title [wip] "ocrd validate" cli, #353 "ocrd validate" cli, #353 Jan 16, 2020
@kba kba merged commit 2910862 into OCR-D:master Jan 21, 2020
@kba kba deleted the validate-cli branch January 21, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants