Skip to content

Conversation

@kba
Copy link
Member

@kba kba commented Jun 7, 2020

Removes unused argument instance and adds ID as a constructor argument.

Required by upcoming PR, so will merge if tests pass.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2020

Codecov Report

Merging #504 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   79.53%   79.53%           
=======================================
  Files          41       41           
  Lines        2516     2516           
  Branches      488      488           
=======================================
  Hits         2001     2001           
  Misses        424      424           
  Partials       91       91           
Impacted Files Coverage Δ
ocrd_models/ocrd_models/ocrd_file.py 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e727aa8...77dda6f. Read the comment docs.

@kba kba merged commit ec818e9 into master Jun 7, 2020
@kba kba deleted the ocrdfile-cleanup branch June 7, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants