wait for domains only in debug mode #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redianthus
force-pushed
the
noworkerwait
branch
from
f11ea2d to
3b17c7e
Compare
1. leading to a deadlock 2. leading to some cases being missing because of a crash in a library each one was hiding the other so it was quite hard to debug, now every exception raised by a domain is displayed instantly which should make things easier in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized it was not a good idea to enable this when benchmarking because it makes performances so much worst that some tests we could solve in 4 secondes are now taking at least 30 seconds to solve and it makes benchmarking on Test-Comp leading to really poor results.
We should only enable this in debug mode.
While doing this, I also realized that something was wrong, and some programs would randomly give "All OK!" or find a bug.
After digging a little bit, I found there was an issue in Synchronizer: OCamlPro/synchronizer#5
After fixing it, I noticed the issue was still there. It was because of the crash in formalsec/smtml#481 ; but that was going unnoticed because of a second bug in Synchronizer + we would print exception only at the end of execution when calling Domain.join (which we would never reach actually).
I fixed all of this. Now we can properly avoid waiting for domains, exceptions get displayed early, and there is a fix for smtml and synchronizer. I can no longer reproduce the issue I was having. 🥳