Skip to content

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Oct 28, 2017

Change the AppVeyor badge to the one attached to the ODM2 org.
If everything works as expected anyone with access to the ODM2 org and an AppVeyor account will have Adim rights to the AppVeyor instance.

@ocefpaf ocefpaf requested a review from lsetiawan October 28, 2017 13:06
@emiliom
Copy link
Member

emiliom commented Oct 28, 2017

AppVeyor failed here. I assume I should hold off on merging, then?

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 28, 2017

AppVeyor failed here. I assume I should hold off on merging, then?

Not really. AppVeyor was never green here since day one.

@emiliom
Copy link
Member

emiliom commented Oct 28, 2017

OK. I can't keep track.

Should I merge? I'm guessing so.

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 28, 2017

It is OK to merge. Addressing those errors are not in our priority list b/c it would require some deep knowledge of databases on Windows.

@emiliom emiliom merged commit 9c28915 into ODM2:master Oct 28, 2017
@ocefpaf ocefpaf deleted the new_badge branch October 28, 2017 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants