use versioneer#84
Merged
emiliom merged 1 commit intoODM2:masterfrom Jun 13, 2017
Merged
Conversation
Member
|
@sreeder, do you want to review this PR, or should I go ahead and merge? FYI, @ocefpaf also recently implemented |
ocefpaf
commented
Jun 13, 2017
| versionfile_build = odm2api/_version.py | ||
| tag_prefix = v | ||
| parentdir_prefix = | ||
|
|
Member
Author
There was a problem hiding this comment.
Note that most of this PR is boilerplate. What needs reviweing is in this file.
Here we are using the prefix v for the version number in the tags, like v1.0.0. A tag like 1.0.0 would be ignored by this configuration! And we are also conforming to the PEP440 for version identification and dependency specification. If you agree with those than it should be OK to merge.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With versioneer all we need to do is to tag a new release and the version should be properly propagated everywhere. Note that I am using a pep440 style, that means tags like
v0.6.0-alphawill be translated to0.6.0a0.There are also some advantages, like GitHub hashes and/or a
dirtyflag when creating releases from branches or from uncommitted changes. This improves reproducibility and manageability of releases.Closes #83
PS: There is a lot of boilerplate code in this PR. but this is done only once. Most of this code won't need any modification in the future.