Skip to content

Conversation

@przet
Copy link
Member

@przet przet commented Oct 31, 2022

Rotation logic changed for all 3 cubes to allow for visual inspection of all faces

Rotation logic changed for all 3 cubes to allow for visual inspection of all faces
@przet przet linked an issue Oct 31, 2022 that may be closed by this pull request
@przet przet changed the title All faces on no tex cube Baseline cube without texture doesn't have all faces rendered Nov 1, 2022
@przet
Copy link
Member Author

przet commented Nov 1, 2022

Some things I am going to leave to other issues (as I want to go over to windows first):

  1. Can fix the rotation logic to inspect the top/bottom faces without needing to go around a full circle (as we then cover faces we already have seen).
  2. At least on the middle cube, there is a model matrix reset issue (evident in the snapping to a different face).
  3. If I am working on 1 and 2, it would be good to also reorder the slots in a more logical fashion (the third slot is the middle cube)

@przet przet merged commit 1da9493 into Linux Nov 1, 2022
@przet przet deleted the baseline_cube_notex_missing_faces branch November 1, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Baseline cube without texture doesn't have all faces rendered

2 participants