Skip to content

Commit 6ee5094

Browse files
committed
perf: ⚡️ Update react-vtkjs-viewport for performance improvement
1 parent 5c5223f commit 6ee5094

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

extensions/vtk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
},
4949
"dependencies": {
5050
"@babel/runtime": "^7.5.5",
51-
"react-vtkjs-viewport": "0.1.4"
51+
"react-vtkjs-viewport": "^0.1.6"
5252
},
5353
"devDependencies": {
5454
"@ohif/core": "^1.2.0",

extensions/vtk/src/OHIFVTKViewport.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ class OHIFVTKViewport extends Component {
153153
switch (sopClassUid) {
154154
case SOP_CLASSES.SEGMENTATION_STORAGE:
155155
throw new Error('Not yet implemented');
156-
156+
/*
157157
const data = handleSegmentationStorage(
158158
stack.imageIds,
159159
displaySetInstanceUid
@@ -168,10 +168,13 @@ class OHIFVTKViewport extends Component {
168168
labelmap: labelmapDataObject,
169169
};
170170
});
171+
*/
171172
default:
172173
imageDataObject = getImageData(stack.imageIds, displaySetInstanceUid);
173174

174-
return loadImageData(imageDataObject).then(() => {
175+
const loadImageDataPromise = loadImageData(imageDataObject);
176+
177+
return loadImageDataPromise.then(() => {
175178
return {
176179
data: imageDataObject.vtkImageData,
177180
};
@@ -265,7 +268,6 @@ class OHIFVTKViewport extends Component {
265268
}
266269

267270
componentWillUnmount() {
268-
console.log(this.props.viewportIndex);
269271
vtkViewportSubscriptionManager.unsubscribe(this.props.viewportIndex);
270272
}
271273

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14969,10 +14969,10 @@ react-transition-group@^4.1.1:
1496914969
loose-envify "^1.4.0"
1497014970
prop-types "^15.6.2"
1497114971

14972-
react-vtkjs-viewport@0.1.4:
14973-
version "0.1.4"
14974-
resolved "https://registry.yarnpkg.com/react-vtkjs-viewport/-/react-vtkjs-viewport-0.1.4.tgz#f5ecc7dd52ab065d54656f36851f49b058ba683f"
14975-
integrity sha512-07hVFJJ9LTy+Z9dgdPiPkaohVb013bgjNgH29MVafnjwH92YOXJzfFbf8/yzzVIZsYCETFf7rVw+oMGQJs5TAA==
14972+
react-vtkjs-viewport@^0.1.6:
14973+
version "0.1.6"
14974+
resolved "https://registry.yarnpkg.com/react-vtkjs-viewport/-/react-vtkjs-viewport-0.1.6.tgz#d9bfb2c27c850c21c07c587405d0d3edcbd31d45"
14975+
integrity sha512-NO5Dx7MXnS6NTG+crIwcGlm1uBFYMTR/tXtLKfTfPwWNakazkqlUuhqpsw2dEcMqEB+v/RmAX6bzrArcjv4M4A==
1497614976
dependencies:
1497714977
date-fns "^2.2.1"
1497814978
gl-matrix "^3.1.0"

0 commit comments

Comments
 (0)