fix: Use same config for branch deploys as for deploy previews#1893
Merged
swederik merged 5 commits intofeat/v2-mainfrom Jul 22, 2020
Merged
fix: Use same config for branch deploys as for deploy previews#1893swederik merged 5 commits intofeat/v2-mainfrom
swederik merged 5 commits intofeat/v2-mainfrom
Conversation
swederik
force-pushed
the
feat/v2-main-deploy-previews
branch
from
a2eddd0 to
73016d2
Compare
swederik
added a commit
that referenced
this pull request
Jul 23, 2020
* fix: Use same config for branch deploys as for deploy previews * chore: remove unnecessary duplicate build-deploy-preview.sh file * fix: Attempt to workaround Netlify cache issues for Lerna repos * chore: Remove useless debug file * fix: try to make Gatsby less slow
swederik
added a commit
that referenced
this pull request
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch deploys are not working at the moment. It looks like it's because the config is only customized for deploy previews. This switches the config to apply to both. Proof it works: https://app.netlify.com/sites/ohif/deploys/5f082a2e7141c1149b297ce6