fix(nginx archive recipe): Fixes to various configuration files.#3624
fix(nginx archive recipe): Fixes to various configuration files.#3624sedghi merged 3 commits intoOHIF:masterfrom
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs canceled.
|
Codecov Report
@@ Coverage Diff @@
## master #3624 +/- ##
=======================================
Coverage 42.54% 42.54%
=======================================
Files 80 80
Lines 1462 1462
Branches 340 340
=======================================
Hits 622 622
Misses 675 675
Partials 165 165 Continue to review full report in Codecov by Sentry.
|
| ENV PATH /usr/src/app/node_modules/.bin:$PATH | ||
|
|
||
| # Copy Files | ||
| COPY .docker /usr/src/app/.docker |
There was a problem hiding this comment.
is there any folder that we don't need to copy? maybe we say copy all excluding this and that?
There was a problem hiding this comment.
I think the list to exclude is bigger than the list to include.
There was a problem hiding this comment.
Also, I couldn't find a way to exclude files using the COPY command. But... I think I may have found a way using the .dockerignore file. Stay tuned.
any unnecessary files and directories.
…F#3624) Co-authored-by: Alireza <ar.sedghi@gmail.com>
2 participants
Context
Fixes #3423
Note that the OpenResty-Orthanc-Keycloak recipe is still broken, but some changes were made for it.
Changes & Results
Various changes to docker, nginx and OHIF configuration files.
Testing
Follow the nginx-image-archive recipe in the OHIF docs.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment